This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a button to mark all rooms as read #3676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Raimist <[email protected]>
turt2live
approved these changes
Nov 26, 2019
Co-Authored-By: Travis Ralston <[email protected]>
t3chguy
reviewed
Nov 26, 2019
| MatrixClientPeg.get().getRooms().forEach(function(element) { | ||
| MatrixClientPeg.get().sendReadReceipt(function(evs) { | ||
| return evs[evs.length - 1] | ||
| }(element.getLiveTimeline()._events), {}); |
There was a problem hiding this comment.
shouldn't be accessing private variables
https://github.com/matrix-org/matrix-react-sdk/pull/2959/files#diff-beb48c1c7c8677b581a5b4177c817f28R661 shows an alternative
There was a problem hiding this comment.
Didn't realize #2959 existed. Let's merge that and you can add another button to there that marks all rooms as read.
turt2live
reviewed
Nov 26, 2019
| _onMarkAllRoomsAsRead = (e) => { | ||
| MatrixClientPeg.get().getRooms().forEach(function(element) { | ||
| MatrixClientPeg.get().sendReadReceipt(function(evs) { | ||
| return evs[evs.length - 1] |
There was a problem hiding this comment.
The linter is annoying sometimes:
Suggested change
| return evs[evs.length - 1] | |
| return evs[evs.length - 1]; |
|
Blocking this on design review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with element-hq/element-web#850 but it would be nice to add a
Shift + Escapekeyboard shortcut like SlackWorkaround for element-hq/element-web#3060