Make thumbnail dimensions mandatory

Fixes #1883
matrix-org · Apr 26, 2019 · 1471546 · 1471546
1 parent c230c2f
commit 1471546
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/api/client-server/content-repo.yaml b/api/client-server/content-repo.yaml
@@ -202,13 +202,15 @@ paths:
           type: integer
           x-example: 64
           name: width
+          required: true
           description: |-
             The *desired* width of the thumbnail. The actual thumbnail may not
             match the size specified.
         - in: query
           type: integer
           x-example: 64
           name: height
+          required: true
           description: |-
             The *desired* height of the thumbnail. The actual thumbnail may not
             match the size specified.

diff --git a/changelogs/client_server/newsfragments/1975.clarification b/changelogs/client_server/newsfragments/1975.clarification
@@ -0,0 +1 @@
+Clarify that ``width`` and ``height`` are required parameters on ``/_matrix/media/r0/thumbnail/{serverName}/{mediaId}``. It is somewhat meaningless to request a thumbnail without specifying a desired size, and Synapse has never permitted such requests.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Clarify that ``width`` and ``height`` are required parameters on ``/_matrix/media/r0/thumbnail/{serverName}/{mediaId}``. It is somewhat meaningless to request a thumbnail without specifying a desired size, and Synapse has never permitted such requests.