Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec says that dimensions on a thumbnail are optional, but does not define the expected behaviour if they are omitted #1883

Closed
richvdh opened this issue Feb 13, 2019 · 4 comments · Fixed by #1975
Closed

Spec says that dimensions on a thumbnail are optional, but does not define the expected behaviour if they are omitted #1883

richvdh opened this issue Feb 13, 2019 · 4 comments · Fixed by #1975
Labels
client-server Client-Server API improvement A suggestion for a relatively simple improvement to the protocol

Comments

@richvdh
Copy link
Member

richvdh commented Feb 13, 2019

https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-media-r0-thumbnail-servername-mediaid.

Personally I'm of the opinion that these should be mandatory, but if they are not we should define the expected behaviour. Note that synapse currently 500s if they are omitted: matrix-org/synapse#2748
This was referenced Feb 13, 2019
Closed
Closed
@turt2live
Copy link
Member

Worth also noting that matrix-media-repo handles this nicely. I'm all for making them required though.

@turt2live turt2live added improvement A suggestion for a relatively simple improvement to the protocol client-server Client-Server API labels Feb 13, 2019
@richvdh
Copy link
Member Author

richvdh commented Feb 13, 2019

what is matrix-media-repo's behaviour, ooi?

@turt2live
Copy link
Member

picks the first configured thumbnail size in the config:
https://github.com/turt2live/matrix-media-repo/blob/master/src/github.com/turt2live/matrix-media-repo/api/r0/thumbnail.go#L42-L44

richvdh added a commit that referenced this issue Apr 26, 2019
@richvdh
Make thumbnail dimensions mandatory
1471546 
Fixes #1883
@richvdh richvdh mentioned this issue Apr 26, 2019
Merged
@richvdh
Copy link
Member Author

richvdh commented Apr 29, 2019

I made an executive decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client-server Client-Server API improvement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make thumbnail dimensions mandatory matrix-org/matrix-spec-proposals
2 participants
@turt2live @richvdh