First pass at mypy for sydent.http #439
Conversation
Rationale: I want to annotate one of these, so that we know the type of headers (which would allow us to detect the problem fixed by #415). if I write a stub for `IResponse` I'll have to write a stub for the entire `iweb` interface module, which seems like a PITA. Also: AFAICS `Response` is the only implementation of `IResponse`. So I feel a bit naughty, but not too naughty.
otherwise we can't call `abortConnection`.
I'm alarmed that this passes locally but doesn't in CI. Let's see if this works.
| # I don't like importing from _sslverify, but IOpenSSLTrustRoot isn't re-exported | ||
| # anywhere else in twisted. | ||
| from twisted.internet._sslverify import IOpenSSLTrustRoot |
There was a problem hiding this comment.
I wonder if we should use if TYPE_CHECKING: for this since it's private?
edit: never mind, this is a stub, that's OK.
There was a problem hiding this comment.
We also use this directly in sydent, see
sydent/sydent/http/httpcommon.py
Line 87 in 356beaf
I don't think OpenSSLCertificateAuthorities is exported in twisted.internet.ssl. /shrug
I felt dirty doing it, but it was a compromise to avoid stubbing the entire world. See the commit message for 793bc15. |
|
thanks! |
|
Many thanks for reviewing @reivilibre ! |
I tried to use `Response` rather than `IResponse` to avoid having to write a stub for the latter. There were other complications down the line from this. It was easier to change my mind, use `stubgen` and polish up the `iweb` stub. See also #439 (comment)
I tried to use `Response` rather than `IResponse` to avoid having to write a stub for the latter. There were other complications down the line from this. It was easier to change my mind, use `stubgen` and polish up the `iweb` stub. See also #439 (comment)
This one was a bit of a nightmare. Lots of interaction with twisted and quite a few false starts.
I've tried to chop this up into manageable commits to make this reviewable.