IAgents should return IResponses
#443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2021 20:51
I tried to use `Response` rather than `IResponse` to avoid having to write a stub for the latter. There were other complications down the line from this. It was easier to change my mind, use `stubgen` and polish up the `iweb` stub. See also #439 (comment)
Merged
reivilibre
requested changes
Oct 28, 2021
| @@ -61,7 +60,7 @@ class FileBodyProducer: | |||
| def resumeProducing(self) -> None: ... | |||
|
|
|||
| def readBody(response: IResponse) -> Deferred[bytes]: ... | |||
|
|
|||
| @implementer(IResponse) # type: ignore[misc] | |||
There was a problem hiding this comment.
why does this need to be ignored? Is it just because the stub doesn't reproduce all the method signatures verbatim?
There was a problem hiding this comment.
That's exactly it. Laziness on my part, really.
There was a problem hiding this comment.
I'll add a comment to explain this.
stubs/twisted/web/iweb.pyi
Outdated
| def setHeader(k: AnyStr, v: AnyStr) -> None: ... | ||
| def redirect(url: AnyStr) -> None: ... | ||
| # returns CACHED or False. CACHED is a string constant but we treat it as | ||
| # a binary object. |
There was a problem hiding this comment.
should be "opaque", thanks. Don't stub when you're tired, kids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #439 I tried to use
Responserather thanIResponsein some annotations,to avoid having to
write a type stub to cover twisted's
iwebinterface.There were other complications down the line from this, because I was now contravening the zope interfaces I was claiming to adhere to. It was easier to change my mind, use
stubgen, and polish up the result by hand. A lot of the work had been done already in annotating the implementation classes.