Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create SBIX font #1

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

create SBIX font #1

wants to merge 29 commits into from

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Jun 1, 2019

No description provided.

@ara4n ara4n marked this pull request as ready for review June 2, 2019 03:39
@ara4n
Copy link
Member Author

ara4n commented Jun 2, 2019

The only remaining problem I can see with this is that some ligatures inexplicably don't take effect - e.g.

1F46D 1F3FB ; fully-qualified # 👭🏻 women holding hands: light skin tone

However, this is broken on both COLR & sbix, and also seems to be Chrome specific (Safari gets it right, somehow).

@turt2live
Copy link
Member

(should this not be contributed upstream rather than here?)

@ara4n
Copy link
Member Author

ara4n commented Sep 13, 2019

judging by how rapidly mozilla#50 is getting merged, i'm not holding my breath for them to accept an invasive change like this for implementing sbix...

@turt2live
Copy link
Member

yup :|

Do we already ship this?

@ara4n
Copy link
Member Author

ara4n commented Sep 13, 2019

yup, it’s the fallback font used for old freetype browsers in riot-web

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge this then - seems to work well in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants