Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm-runner): implement VM runner storage layer #1651

Merged
merged 49 commits into from
Apr 23, 2024
Merged

feat(vm-runner): implement VM runner storage layer #1651

merged 49 commits into from
Apr 23, 2024

Conversation

itegulov
Copy link
Contributor

@itegulov itegulov commented Apr 11, 2024 •
edited
Loading

What ❔

Adds an abstraction that can load unprocessed batches as well as implement ReadStorageFactory. Implementation largely reuses the existing primitives from state keeper and they had to be generalized slightly.

Why ❔

One of the components for the upcoming VM runner

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@itegulov itegulov requested a review from perekopskiy April 11, 2024 12:27
perekopskiy
perekopskiy reviewed Apr 12, 2024
View reviewed changes
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Show resolved Hide resolved
perekopskiy
perekopskiy reviewed Apr 17, 2024
View reviewed changes
core/lib/dal/src/transactions_dal.rs Outdated Show resolved Hide resolved
core/lib/state/src/storage_factory.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
core/lib/zksync_core/src/vm_runner/storage.rs Outdated Show resolved Hide resolved
@itegulov itegulov force-pushed the daniyar/pla-865-vm-runner-storage-impl branch from 0766721 to 793ed21 Compare April 19, 2024 05:48
perekopskiy
perekopskiy previously approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@perekopskiy perekopskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please fix lints

@itegulov itegulov enabled auto-merge April 23, 2024 16:37
@itegulov itegulov added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@itegulov itegulov added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@itegulov itegulov added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 543f9e9 Apr 23, 2024
42 checks passed
@itegulov itegulov deleted the daniyar/pla-865-vm-runner-storage-impl branch April 23, 2024 18:23
This was referenced Apr 23, 2024
Merged
Merged
RomanBrodetski pushed a commit that referenced this pull request Apr 30, 2024
@zksync-era-bot @perekopskiy
chore(main): release core 24.0.0 (#1758)
e9d41a6 
🤖 I have created a release *beep* *boop*
---


##
[24.0.0](core-v23.1.0...core-v24.0.0)
(2024-04-30)


### ⚠ BREAKING CHANGES

* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
* shared bridge
([#298](#298))

### Features

* **api:** Allow granular max response size config
([#1642](#1642))
([83c4034](83c4034))
* **api:** Improve logging for API server
([#1792](#1792))
([50fbda5](50fbda5))
* **api:** Track params for RPC methods
([#1673](#1673))
([1a34c8b](1a34c8b))
* **configs:** move ecosystem contracts to contracts
([#1606](#1606))
([9d52180](9d52180))
* EcPairing precompile as system contract
([#1761](#1761))
([3071622](3071622))
* Include create2 factory in genesis
([#1775](#1775))
([597280b](597280b))
* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
([6a557f7](6a557f7))
* **prover:** remove redundant config fields
([#1787](#1787))
([a784ea6](a784ea6))
* shared bridge
([#298](#298))
([8c3478a](8c3478a))
* **tree:** Improved tree pruning
([#1532](#1532))
([bcb192c](bcb192c))
* **vm-runner:** implement VM runner storage layer
([#1651](#1651))
([543f9e9](543f9e9))
* **vm:** Extend bootloader memory in the new version
([#1807](#1807))
([f461b28](f461b28))


### Bug Fixes

* **api:** Fix extra DB connection acquisition during tx submission
([#1793](#1793))
([9c6ed83](9c6ed83))
* **en:** correct en config vars
([#1809](#1809))
([d340fbc](d340fbc))
* **en:** Remove duplicate reorg detector
([#1783](#1783))
([3417941](3417941))
* **kl-factory:** base token ether tests
([#1746](#1746))
([6cf14a0](6cf14a0))
* **prover:** Fix panics if prover's config is not ready
([#1822](#1822))
([21d90d7](21d90d7))
* **snapshots_creator:** Remove snapshots during reverts
([#1757](#1757))
([8d587fd](8d587fd))
* **types:** Add LegacyMixedCall
([#1773](#1773))
([2b236fe](2b236fe))
* v23 api typo
([#1821](#1821))
([a11fa86](a11fa86))
* Weaker assert for protocol version for operations
([#1800](#1800))
([11898c2](11898c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
@zksync-era-bot
chore(main): release prover 14.0.0 (#1772)
f6e63e1 
🤖 I have created a release *beep* *boop*
---


##
[14.0.0](prover-v13.0.0...prover-v14.0.0)
(2024-05-06)


### ⚠ BREAKING CHANGES

* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
* shared bridge
([#298](#298))

### Features

* **config:** Wrap sensitive urls
([#1828](#1828))
([c8ee740](c8ee740))
* **Prover CLI:** `status batch` command
([#1638](#1638))
([3fd6d65](3fd6d65))
* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
([6a557f7](6a557f7))
* **prover:** remove redundant config fields
([#1787](#1787))
([a784ea6](a784ea6))
* shared bridge
([#298](#298))
([8c3478a](8c3478a))
* **vm-runner:** implement VM runner storage layer
([#1651](#1651))
([543f9e9](543f9e9))


### Bug Fixes

* **en:** Remove duplicate reorg detector
([#1783](#1783))
([3417941](3417941))
* **prover:** Use all 1.5.0 groups for nodes
([#1851](#1851))
([70178e5](70178e5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Deniallugo pushed a commit that referenced this pull request May 7, 2024
@zksync-era-bot @Deniallugo
chore(main): release prover 14.0.0 (#1772)
cd912af 
🤖 I have created a release *beep* *boop*
---


##
[14.0.0](prover-v13.0.0...prover-v14.0.0)
(2024-05-06)


### ⚠ BREAKING CHANGES

* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
* shared bridge
([#298](#298))

### Features

* **config:** Wrap sensitive urls
([#1828](#1828))
([c8ee740](c8ee740))
* **Prover CLI:** `status batch` command
([#1638](#1638))
([3fd6d65](3fd6d65))
* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
([6a557f7](6a557f7))
* **prover:** remove redundant config fields
([#1787](#1787))
([a784ea6](a784ea6))
* shared bridge
([#298](#298))
([8c3478a](8c3478a))
* **vm-runner:** implement VM runner storage layer
([#1651](#1651))
([543f9e9](543f9e9))


### Bug Fixes

* **en:** Remove duplicate reorg detector
([#1783](#1783))
([3417941](3417941))
* **prover:** Use all 1.5.0 groups for nodes
([#1851](#1851))
([70178e5](70178e5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@RomanBrodetski RomanBrodetski Awaiting requested review from RomanBrodetski

@slowli slowli Awaiting requested review from slowli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itegulov @perekopskiy