Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vm-runner): implement VM runner main body #1955

Merged
merged 24 commits into from
May 23, 2024
Merged

feat(vm-runner): implement VM runner main body #1955

merged 24 commits into from
May 23, 2024

Conversation

itegulov
Copy link
Contributor

What ❔

Main body of VM runner that combines all previously implemented components into a reusable framework that re-executes blocks in VM.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@itegulov itegulov marked this pull request as ready for review May 20, 2024 07:28
slowli
slowli reviewed May 20, 2024
View reviewed changes
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/process.rs Show resolved Hide resolved
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/storage.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/tests/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/tests/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/tests/storage.rs Outdated Show resolved Hide resolved
@itegulov itegulov requested a review from slowli May 21, 2024 07:30
perekopskiy
perekopskiy previously approved these changes May 21, 2024
View reviewed changes
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
slowli
slowli reviewed May 21, 2024
View reviewed changes
core/node/state_keeper/src/testonly/test_batch_executor.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/process.rs Show resolved Hide resolved
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
core/node/vm_runner/src/process.rs Outdated Show resolved Hide resolved
@itegulov itegulov requested a review from slowli May 22, 2024 07:39
@itegulov itegulov added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit bf5b6c2 May 23, 2024
44 checks passed
@itegulov itegulov deleted the daniyar/pla-867-vm-runner-main branch May 23, 2024 13:06
@zksync-era-bot zksync-era-bot mentioned this pull request May 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
@zksync-era-bot
chore(main): release core 24.5.0 (#2004)
e0923ff 
🤖 I have created a release *beep* *boop*
---


##
[24.5.0](core-v24.4.0...core-v24.5.0)
(2024-05-30)


### Features

* Add protocol_version label to WG jobs metric
([#2009](#2009))
([e0a3393](e0a3393))
* **config:** remove zksync home
([#2022](#2022))
([d08fe81](d08fe81))
* **en:** Improve tree snapshot recovery
([#1938](#1938))
([5bc8234](5bc8234))
* Make house keeper emit correct protocol version
([#2062](#2062))
([a58a7e8](a58a7e8))
* **node_framework:** Migrate main node to the framework
([#1997](#1997))
([27a26cb](27a26cb))
* **node_framework:** Synchronize pools layer with logic in
initialize_components
([#2079](#2079))
([3202461](3202461))
* Protocol semantic version
([#2059](#2059))
([3984dcf](3984dcf))
* **prover:** Adnotate prover queue metrics with protocol version
([#1893](#1893))
([d1e1004](d1e1004))
* save writes needed for tree in state keeper
([#1965](#1965))
([471af53](471af53))
* **test:** Add filebased config support for integration tests
([#2043](#2043))
([be3ded9](be3ded9))
* **vm-runner:** implement VM runner main body
([#1955](#1955))
([bf5b6c2](bf5b6c2))


### Bug Fixes

* **API:** polish web3 api block-related types
([#1994](#1994))
([6cd3c53](6cd3c53))
* **en:** chunk factory deps
([#2077](#2077))
([4b9e6fa](4b9e6fa))
* **en:** Fix recovery-related metrics
([#2014](#2014))
([86355d6](86355d6))
* **eth-watch:** Do not track for stm, only for diamond proxy
([#2080](#2080))
([87adac9](87adac9))
* fix metrics reporting wrong values
([#2065](#2065))
([2ec010a](2ec010a))
* **loadtest:** resolve unit conversion error in loadtest metrics
([#1987](#1987))
([b5870a0](b5870a0))
* **merkle-tree:** Fix incoherent Merkle tree view
([#2071](#2071))
([2fc9a6c](2fc9a6c))
* **metadata-calculator:** protective reads sort
([#2087](#2087))
([160c13c](160c13c))
* **node_framework:** Fix the connection pool size for the catchup task
([#2046](#2046))
([c00a2eb](c00a2eb))
* **node_framework:** Use custom pool for commitiment generator
([#2076](#2076))
([994df8f](994df8f))
* **protocol_version:** Add backward compatibility
([#2097](#2097))
([391624b](391624b))
* **pruning:** Fix DB pruner responsiveness during shutdown
([#2058](#2058))
([0a07312](0a07312))
* **zk_toolbox:** Use both folders for loading contracts
([#2030](#2030))
([97c6d5c](97c6d5c))


### Performance Improvements

* **commitment-generator:** Run commitment generation for multiple
batches in parallel
([#1984](#1984))
([602bf67](602bf67))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perekopskiy perekopskiy perekopskiy approved these changes

@slowli slowli slowli approved these changes

@Artemka374 Artemka374 Awaiting requested review from Artemka374

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itegulov @slowli @perekopskiy