[MM-54589] Report job start failure #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
3: Reviews Complete
streamer45
added
the
Do Not Merge/Awaiting PR
* Refactor connectivity check to be more resilient * Bump packages deps * Report job start * [MM-54747] Implement structured logging (#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR implements some logic to report a failure on start to the plugin side. This is especially needed to cover the case in which the bot fails to connect which would otherwise trigger a rather long timeout (currently set to 2 minutes). With this, if the browser process were to fail for any reasons, we'd be surfacing the error to the user right away.
As mentioned in #44 (comment) I'd probably this approach in place of the custom websocket event.
Related PR
mattermost/mattermost-plugin-calls#542
Ticket Link
https://mattermost.atlassian.net/browse/MM-54589