Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-54749] Make connectivity check more resilient to errors #47

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

streamer45
Copy link
Contributor

Summary

PR does a couple of things:

  • Reworks the initial connectivity check polling so that it's more resilient to one off errors.
    • Before it was coupled in the same chromedp.Run command which meant that a single random network failure would cause the whole thing to fail. Now we continuously attempt until we reach the timeout regardless of errors which we simply log.
  • Posting an explicit status update for when the recording is actually starting.

Ticket Link

https://mattermost.atlassian.net/browse/MM-54749

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Oct 4, 2023
@streamer45 streamer45 requested a review from cpoile October 4, 2023 18:21
@streamer45 streamer45 self-assigned this Oct 4, 2023
@streamer45 streamer45 added this to the v0.5.0 milestone Oct 4, 2023
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer, great!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 4, 2023
* Implement structured logging

* Bump golangci-lint
@streamer45 streamer45 merged commit 6754e93 into MM-54589 Oct 4, 2023
@streamer45 streamer45 deleted the MM-54749 branch October 4, 2023 22:38
streamer45 added a commit that referenced this pull request Oct 4, 2023
… logging

* [MM-54589] Report job start failure (#46)

* [MM-54749] Make connectivity check more resilient to errors (#47)

* [MM-54747] Implement structured logging (#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants