Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-54272 - Upgrade npm, use modern webapp #516

Closed
wants to merge 9 commits into from
Closed

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Sep 8, 2023

Summary

  • Needed to upgrade a few deps.
  • Opening a new PR off main was easiest. Answered questions in the previous PR

Ticket Link

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Sep 8, 2023
@cpoile cpoile requested a review from streamer45 September 8, 2023 15:17
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (00a57a6) 5.42% compared to head (67e50eb) 5.42%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #516   +/-   ##
=====================================
  Coverage   5.42%   5.42%           
=====================================
  Files         24      24           
  Lines       4387    4387           
=====================================
  Hits         238     238           
  Misses      4132    4132           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpoile
Copy link
Member Author

cpoile commented Sep 8, 2023

This will require https://git.internal.mattermost.com/qa/calls-e2e-testing/-/merge_requests/37 for build & e2e to run. Or at least it did... Now it's coming up with something different. Looking into it.
Guess we upgraded our builder without a PR. nice? :)

@streamer45 streamer45 added this to the v0.20.0 / MM 9.1 milestone Sep 8, 2023
@streamer45
Copy link
Collaborator

mystery solved I suppose :D

@cpoile
Copy link
Member Author

cpoile commented Nov 1, 2023

Replaced by #555

@cpoile cpoile closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants