Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-54272 - Upgrade npm and mattermost-webapp dependency #555

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Nov 1, 2023

Summary

Note: doesn't include the newer simple imports plugin; all the import reordering here was due to a few of the imports changing and that causing the existing import-order plugin to ask for changes. I tried to confine most of those ordering changes to the second commit. The first commit are the important changes.

Ticket Link

second

third

'fix rest client'

merge conflicts, more to go

looks like everything works, but import-order is wrong
@cpoile cpoile changed the title MM-54272 - Upgrade npm MM-54272 - Upgrade npm and mattermost-webapp dependency Nov 1, 2023
@cpoile cpoile requested a review from streamer45 November 1, 2023 12:23
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (d834de2) 5.26% compared to head (07c6892) 5.49%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #555      +/-   ##
========================================
+ Coverage   5.26%   5.49%   +0.22%     
========================================
  Files         24      24              
  Lines       4479    4532      +53     
========================================
+ Hits         236     249      +13     
- Misses      4224    4265      +41     
+ Partials      19      18       -1     
Files Coverage Δ
server/rtcd.go 6.82% <0.00%> (-0.02%) ⬇️
server/state.go 42.78% <73.77%> (ø)
server/session.go 0.00% <0.00%> (ø)
server/websocket.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45
Copy link
Collaborator

Not sure how worried we should be about this, just a bit annoying at this point:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: {
npm WARN EBADENGINE     node: '^16 || ^15 || ^14 || ^13 || ^12 || ^11 || ^10 || ^9 || ^8 || ^7 || ^6'
npm WARN EBADENGINE   },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }

@cpoile
Copy link
Member Author

cpoile commented Nov 2, 2023

@streamer45 yep I saw that, I'll try to fix that in the pr for the simpler import ordering.

Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, it's working very well. Just started an E2E pipeline running the new builder to make sure it works as expected, after which we can merge. Thanks!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 2, 2023
@streamer45 streamer45 added this to the v0.21.0 / MM 9.3 milestone Nov 2, 2023
@streamer45
Copy link
Collaborator

@cpoile Looks like there's a stubborn e2e test failing. Not sure if flaky or timing out?

@cpoile
Copy link
Member Author

cpoile commented Nov 2, 2023

@streamer45 it might be timing out because of load? It looked like the element (join call header button) was visible but it just didn't find it. Trying again.

@cpoile cpoile merged commit 1cc67c8 into main Nov 2, 2023
@cpoile cpoile deleted the MM-54272-upgrade-npm-3 branch November 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants