-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-54272 - Upgrade npm and mattermost-webapp dependency #555
Conversation
second third 'fix rest client' merge conflicts, more to go looks like everything works, but import-order is wrong
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
========================================
+ Coverage 5.26% 5.49% +0.22%
========================================
Files 24 24
Lines 4479 4532 +53
========================================
+ Hits 236 249 +13
- Misses 4224 4265 +41
+ Partials 19 18 -1
☔ View full report in Codecov by Sentry. |
Not sure how worried we should be about this, just a bit annoying at this point:
|
@streamer45 yep I saw that, I'll try to fix that in the pr for the simpler import ordering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, it's working very well. Just started an E2E pipeline running the new builder to make sure it works as expected, after which we can merge. Thanks!
@cpoile Looks like there's a stubborn e2e test failing. Not sure if flaky or timing out? |
@streamer45 it might be timing out because of load? It looked like the element (join call header button) was visible but it just didn't find it. Trying again. |
Summary
Note: doesn't include the newer simple imports plugin; all the import reordering here was due to a few of the imports changing and that causing the existing import-order plugin to ask for changes. I tried to confine most of those ordering changes to the second commit. The first commit are the important changes.
Ticket Link