[MM-61555] Fix rendering issue with screen sharing player #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Nov 6, 2024
Comment on lines
+55
to
+60
| // { | ||
| // name: 'firefox', | ||
| // use: { | ||
| // browserName: 'firefox', | ||
| // }, | ||
| // }, |
There was a problem hiding this comment.
Keeping this commented for later?
There was a problem hiding this comment.
Yep, that's the plan
Comment on lines
+448
to
+451
| // Verify the player is actually showing something | ||
| const box = await popOut.locator('#screen-player').boundingBox(); | ||
| expect(box?.width).toBeGreaterThan(1000); | ||
| expect(box?.height).toBeGreaterThan(500); |
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Nov 11, 2024
* Fix rendering issue with screen sharing player * Add comment
streamer45
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is most likely a CSS regression in Firefox (the way flexbox behaves with a child with 100% height). I was only able to reproduce on version 139 so far. Chrome works as expected.
That said, even the Chrome rendering wasn't great since it created an extra gap between the actual player content and the wrapper. This feels better now.
I added an e2e test and ran it on Firefox, but it didn't reproduce the issue since Playwright currently ships Firefox 131. Enabling the whole pipeline on Firefox requires far more work (tracking at https://mattermost.atlassian.net/browse/MM-61558).
Screenshots
Before
After
Ticket Link
https://mattermost.atlassian.net/browse/MM-61555