Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61538] Fix incoming call banner tooltip placement in global widget #901

Merged
merged 1 commit into from
Nov 7, 2024
Merged

[MM-61538] Fix incoming call banner tooltip placement in global widget #901

merged 1 commit into from
Nov 7, 2024

Conversation

streamer45
Copy link
Collaborator

Summary

Fixing a tooltip placement issue that caused it to be out of the bounds of our global widget window.

Screenshot

Before

image

After

image

Ticket Link

https://mattermost.atlassian.net/browse/MM-61538

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Nov 7, 2024
@streamer45 streamer45 added this to the v1.3.0 / MM v10.3 milestone Nov 7, 2024
@streamer45 streamer45 self-assigned this Nov 7, 2024
@streamer45 streamer45 requested a review from cpoile November 7, 2024 19:37
cpoile
cpoile approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good. :)

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 7, 2024
@streamer45 streamer45 merged commit b5a4211 into main Nov 7, 2024
18 checks passed
@streamer45 streamer45 deleted the MM-61538 branch November 7, 2024 20:04
streamer45 added a commit that referenced this pull request Nov 11, 2024
@streamer45
Fix incoming call banner tooltip placement in global widget (#901)
e2c886b
streamer45 added a commit that referenced this pull request Nov 11, 2024
@streamer45
Prepare v0.29.4 (#905)
a9c4e41 
* Add tooltip to screen source names (#893)

* [MM-61555] Fix rendering issue with screen sharing player (#899)

* Fix rendering issue with screen sharing player

* Add comment

* Fix incoming call banner tooltip placement in global widget (#901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpoile cpoile cpoile approved these changes

Assignees

@streamer45 streamer45

Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0 / MM v10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@streamer45 @cpoile