Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fly-deploy.yml #40

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Update fly-deploy.yml #40

merged 1 commit into from
Dec 26, 2024

Conversation

mauvehed
Copy link
Owner

@mauvehed mauvehed commented Dec 26, 2024

Summary by Sourcery

CI:

  • Grant write access to pull requests to the deploy workflow.

Copy link

sourcery-ai bot commented Dec 26, 2024

Reviewer's Guide by Sourcery

This pull request updates the fly-deploy.yml file to include permissions for reading contents, writing to pull requests, and reading from pull requests.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added permissions to the workflow.
  • Added contents: read permission.
  • Added pull-requests: write permission.
.github/workflows/fly-deploy.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@mauvehed mauvehed merged commit 8dc2a44 into main Dec 26, 2024
3 checks passed
@mauvehed mauvehed deleted the mauvehed-patch-1 branch December 26, 2024 13:41
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mauvehed - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟡 Security: 1 issue found
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

permissions:
contents: read
pull-requests: write

steps:
- uses: actions/checkout@v4
- uses: superfly/flyctl-actions/setup-flyctl@master
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 suggestion (security): Consider pinning to a specific version instead of using @master

Using a floating reference like @master could expose the workflow to supply chain attacks if the upstream repository is compromised. Pin to a specific version or commit hash for better security and reproducibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant