add LPCXresso LPC1769 target #435
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,7 +16,7 @@ | |||
| */ | |||
|
|
|||
| #if defined(DEVICE_USBDEVICE) && DEVICE_USBDEVICE && \ | |||
| (defined(TARGET_LPC1768) || defined(TARGET_LPC2368) || defined(TARGET_LPC2460)) | |||
| (defined(TARGET_LPC1768) || defined(TARGET_LPC2368) || defined(TARGET_LPC2460) || defined(TARGET_LPC17XX)) | |||
There was a problem hiding this comment.
Should this be defined(TARGET_LPC176X)?
| P3_0, P3_1, P3_2, P3_3, P3_4, P3_5, P3_6, P3_7, P3_8, P3_9, P3_10, P3_11, P3_12, P3_13, P3_14, P3_15, P3_16, P3_17, P3_18, P3_19, P3_20, P3_21, P3_22, P3_23, P3_24, P3_25, P3_26, P3_27, P3_28, P3_29, P3_30, P3_31, | ||
| P4_0, P4_1, P4_2, P4_3, P4_4, P4_5, P4_6, P4_7, P4_8, P4_9, P4_10, P4_11, P4_12, P4_13, P4_14, P4_15, P4_16, P4_17, P4_18, P4_19, P4_20, P4_21, P4_22, P4_23, P4_24, P4_25, P4_26, P4_27, P4_28, P4_29, P4_30, P4_31, | ||
|
|
||
| // mbed DIP Pin Names |
There was a problem hiding this comment.
Is this list correct for this board?
| CONSOLE_TX = P0_2, | ||
| CONSOLE_RX = P0_3, | ||
|
|
||
| // Arch Pro Pin Names |
There was a problem hiding this comment.
Is this list correct for this board?
|
Since LPC1769 (unlike LPC1768) can go up to 120MHz, let's increase the clock frequency if possible! |
|
Yes, clock option is already on the todo list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR adds an older LPCXpresso LPC1769 target. Oldie but Goldie.
It adds also the MCU_LPC176X for modified MCU files, the existing MCU_LPC1768 is not changed.
Impact of changes
Migration actions required
Documentation
Needs updated documentation in Mbed-CE Wiki pages for this target.
Pull request type
Test results
Todo: