Ignore hotkeys when shift is down #37
Conversation
|
Hi Kris. As I said in issue #35, I guess a better solution is to ignore any keystroke when a key modifier is on, not only the shift key. I think that will make clear that only the hotkeys alone work, not any other combination of them. Would you change your PR to address the other modifier keys? Also, I need to ask you to write tests in order to cover that changes. That's very important for me to accept pull requests. In addition to that, please add a prefix to your commit message indicating what the commit is about and what part of the code it affects. In your case, I'd say it would be I'll appreciate if you could do those fixes. :) |
|
Certainly. I've added checks for all modifiers. Also started adding a test for one specific case, but couldn't get it to pass right now -- can you spot any obvious issues? I'll take a look again in a day or two when I get the time. |
|
I apologize for not getting back to this. Glad you were able to finish it. Very grateful for your work on this project. |
|
Hi Kris. I've worked on some other issues this weekend and ended up fixing this one as well. It'll ship with next release (1.0.1). Thanks for your time reporting that bug and sending this PR. 👍 Kind regards. |
Fixes #35