config: Update githubUser to collection

Part of the preparation for #11.
mbland · Nov 5, 2017 · 52a5a31 · 52a5a31
1 parent 924b6ae
commit 52a5a31
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/config/slack-emoji-issues.json b/config/slack-emoji-issues.json
@@ -1,5 +1,5 @@
 {
-  "githubUser": "mbland",
+  "collection": "mbland",
   "githubApiToken": "<github-api-token>",
   "slackApiToken": "<slack-api-token>",
   "githubTimeout": 5000,

diff --git a/lib/config.js b/lib/config.js
@@ -13,7 +13,7 @@ function Config(config, updates) {
 
   validate(config)
 
-  this.githubUser = config.githubUser
+  this.collection = config.collection
   this.githubApiToken = config.githubApiToken
   this.githubTimeout = config.githubTimeout
   this.slackApiToken = config.slackApiToken
@@ -26,7 +26,7 @@ function Config(config, updates) {
 
 var schema = {
   requiredTopLevelFields: {
-    githubUser: 'GitHub organization or username',
+    collection: 'Organization, username, or project',
     githubApiToken: 'GitHub API access token',
     githubTimeout: 'GitHub API timeout limit in milliseconds',
     slackApiToken: 'Slack API access token',

diff --git a/lib/github-client.js b/lib/github-client.js
@@ -9,7 +9,7 @@ var url = require('url')
 module.exports = GitHubClient
 
 function GitHubClient(config) {
-  this.user = config.githubUser
+  this.collection = config.collection
   this.apiToken = config.githubApiToken
   this.timeout = config.githubTimeout
   this.baseurl = url.parse(config.githubApiBaseUrl ||
@@ -27,7 +27,7 @@ function getHttpOptions(client, repository, paramsStr) {
     protocol: baseurl.protocol,
     host: baseurl.hostname,
     port: baseurl.port,
-    path: baseurl.pathname + 'repos/' + client.user + '/' + repository +
+    path: baseurl.pathname + 'repos/' + client.collection + '/' + repository +
       '/issues',
     method: 'POST',
     headers: {

diff --git a/lib/reaction-issue-filer.js b/lib/reaction-issue-filer.js
@@ -168,7 +168,7 @@ Impl.prototype.fileIssue = function(getReactionsResponse) {
 
   metadata = parseMetadata(getReactionsResponse, this.channel)
   this.logger.info(this.msgId, 'filing GitHub issue in ' +
-    this.githubClient.user + '/' + githubRepository)
+    this.githubClient.collection + '/' + githubRepository)
 
   return this.githubClient.fileNewIssue(metadata, githubRepository)
     .catch(this.abort('failed to create a GitHub issue'))

diff --git a/tests/config-test.js b/tests/config-test.js
@@ -19,7 +19,7 @@ describe('Config', function() {
 
   it('should raise errors for missing required fields', function() {
     var errors = [
-          'missing githubUser',
+          'missing collection',
           'missing githubApiToken',
           'missing githubTimeout',
           'missing slackApiToken',

diff --git a/tests/helpers/test-config-invalid.json b/tests/helpers/test-config-invalid.json
@@ -1,5 +1,5 @@
 {
-  "githubUser": "mbland",
+  "collection": "mbland",
   "githubTimeout": 5000,
   "slackTimeout": 5000,
   "successReaction": "heavy_check_mark"

diff --git a/tests/helpers/test-config.json b/tests/helpers/test-config.json
@@ -1,5 +1,5 @@
 {
-  "githubUser": "mbland",
+  "collection": "mbland",
   "githubApiToken": "<github-api-token>",
   "githubTimeout": 5000,
   "slackApiToken": "<slack-api-token>",