Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jira support #11

Open
4 tasks
mbland opened this issue Sep 22, 2017 · 1 comment
Open
4 tasks

Add Jira support #11

mbland opened this issue Sep 22, 2017 · 1 comment
Assignees
Milestone

Comments

@mbland
Copy link
Owner

mbland commented Sep 22, 2017

This will require:

  • adding a new JiraClient class, with slight updates to the existing GithubClient interface to match a new IssuesClient interface
  • updating Config to encapsulate the github* settings, and create a corresponding set of jira* settings
  • updating Rule to change githubRepository to issuesBoard or some such
  • adding an IssuesClientFactory or some such to instantiate the correct issues client in index.js, based on the validated Config

References:

@mbland mbland added this to the v1.2.0 milestone Sep 22, 2017
@mbland mbland self-assigned this Sep 22, 2017
@mbland
Copy link
Owner Author

mbland commented Nov 5, 2017

While beginning to do some refactoring to make the existing code more generic, I realize that the current Config.githubUser can not only become Config.collection, but that Rule.target doesn't have to be a string: for the JIRA implementation, it can be an object directly injected into the API request body.

At the same time, Config.collection can become the default GitHub org/user or default JIRA project ID/key, which can then be overridden by individual Rule.target objects.

mbland pushed a commit that referenced this issue Oct 31, 2018
Part of the preparation for #11.
mbland pushed a commit that referenced this issue Oct 31, 2018
Part of the preparation for #11.
mbland pushed a commit that referenced this issue Oct 31, 2018
Part of the preparation for #11.
mbland pushed a commit that referenced this issue Oct 31, 2018
Part of the preparation for #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant