You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While beginning to do some refactoring to make the existing code more generic, I realize that the current Config.githubUser can not only become Config.collection, but that Rule.target doesn't have to be a string: for the JIRA implementation, it can be an object directly injected into the API request body.
At the same time, Config.collection can become the default GitHub org/user or default JIRA project ID/key, which can then be overridden by individual Rule.target objects.
This will require:
JiraClient
class, with slight updates to the existingGithubClient
interface to match a newIssuesClient
interfaceConfig
to encapsulate thegithub*
settings, and create a corresponding set ofjira*
settingsRule
to changegithubRepository
toissuesBoard
or some suchIssuesClientFactory
or some such to instantiate the correct issues client inindex.js
, based on the validatedConfig
References:
The text was updated successfully, but these errors were encountered: