config: Update githubTimeout to issuesTimeout

Part of the preparation for #11.
mbland · Nov 5, 2017 · c5b79cc · c5b79cc
1 parent cfbf8d3
commit c5b79cc
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/config/slack-emoji-issues.json b/config/slack-emoji-issues.json
@@ -2,7 +2,7 @@
   "collection": "mbland",
   "githubApiToken": "<github-api-token>",
   "slackApiToken": "<slack-api-token>",
-  "githubTimeout": 5000,
+  "issuesTimeout": 5000,
   "slackTimeout": 5000,
   "successReaction": "heavy_check_mark",
   "rules": [

diff --git a/lib/config.js b/lib/config.js
@@ -15,7 +15,7 @@ function Config(config, updates) {
 
   this.collection = config.collection
   this.githubApiToken = config.githubApiToken
-  this.githubTimeout = config.githubTimeout
+  this.issuesTimeout = config.issuesTimeout
   this.slackApiToken = config.slackApiToken
   this.slackTimeout = config.slackTimeout
   this.successReaction = config.successReaction
@@ -28,7 +28,7 @@ var schema = {
   requiredTopLevelFields: {
     collection: 'Organization, username, or project',
     githubApiToken: 'GitHub API access token',
-    githubTimeout: 'GitHub API timeout limit in milliseconds',
+    issuesTimeout: 'Issue tracking system API timeout limit in milliseconds',
     slackApiToken: 'Slack API access token',
     slackTimeout: 'Slack API timeout limit in milliseconds',
     successReaction: 'emoji used to indicate an issue was successfully filed',

diff --git a/lib/github-client.js b/lib/github-client.js
@@ -11,7 +11,7 @@ module.exports = GitHubClient
 function GitHubClient(config) {
   this.collection = config.collection
   this.apiToken = config.githubApiToken
-  this.timeout = config.githubTimeout
+  this.timeout = config.issuesTimeout
   this.baseurl = url.parse(config.githubApiBaseUrl ||
     constants.GITHUB_API_BASE_URL)
   this.requestFactory = (this.baseurl.protocol === 'https:') ? https : http

diff --git a/tests/config-test.js b/tests/config-test.js
@@ -21,7 +21,7 @@ describe('Config', function() {
     var errors = [
           'missing collection',
           'missing githubApiToken',
-          'missing githubTimeout',
+          'missing issuesTimeout',
           'missing slackApiToken',
           'missing slackTimeout',
           'missing successReaction',

diff --git a/tests/helpers/test-config-invalid.json b/tests/helpers/test-config-invalid.json
@@ -1,6 +1,6 @@
 {
   "collection": "mbland",
-  "githubTimeout": 5000,
+  "issuesTimeout": 5000,
   "slackTimeout": 5000,
   "successReaction": "heavy_check_mark"
 }
diff --git a/tests/helpers/test-config.json b/tests/helpers/test-config.json
@@ -1,7 +1,7 @@
 {
   "collection": "mbland",
   "githubApiToken": "<github-api-token>",
-  "githubTimeout": 5000,
+  "issuesTimeout": 5000,
   "slackApiToken": "<slack-api-token>",
   "slackTimeout": 5000,
   "successReaction": "heavy_check_mark",