refactor: Extract the render component part of RoutePropertiesCard as its own component #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… its own component
Coverage of commit
|
joshlarson
commented
May 20, 2024
| @@ -224,27 +224,23 @@ const VariantPicker = ({ | |||
| } | |||
| } | |||
|
|
|||
| const RoutePropertiesCard = ({ | |||
| export const RoutePropertiesCardRender = ({ | |||
There was a problem hiding this comment.
Would love to come up with a better name for this
firestack
reviewed
May 20, 2024
Comment on lines
317
to
344
| const RoutePropertiesCard = ({ | ||
| routePatterns, | ||
| selectedRoutePatternId, | ||
| selectRoutePattern, | ||
| onClose, | ||
| }: { | ||
| routePatterns: ByRoutePatternId<RoutePattern> | ||
| selectedRoutePatternId: RoutePatternId | ||
| selectRoutePattern: (routePattern: RoutePattern) => void | ||
| onClose?: () => void | ||
| }) => { | ||
| const selectedRoutePattern = routePatterns[selectedRoutePatternId] | ||
| const route: Route | null = useRoute(selectedRoutePattern?.routeId) | ||
|
|
||
| if (!route || selectedRoutePattern === undefined) { | ||
| return <></> | ||
| } | ||
|
|
||
| return ( | ||
| <RoutePropertiesCardRender | ||
| routePatterns={routePatterns} | ||
| route={route} | ||
| selectedRoutePattern={selectedRoutePattern} | ||
| selectRoutePattern={selectRoutePattern} | ||
| onClose={onClose} | ||
| /> | ||
| ) | ||
| } |
There was a problem hiding this comment.
suggestion(non-blocking): What do you think about this? I know it'd cause a diff (:/) in the rest of the application (and the Render suffix would need to be left off)
Suggested change
| const RoutePropertiesCard = ({ | |
| routePatterns, | |
| selectedRoutePatternId, | |
| selectRoutePattern, | |
| onClose, | |
| }: { | |
| routePatterns: ByRoutePatternId<RoutePattern> | |
| selectedRoutePatternId: RoutePatternId | |
| selectRoutePattern: (routePattern: RoutePattern) => void | |
| onClose?: () => void | |
| }) => { | |
| const selectedRoutePattern = routePatterns[selectedRoutePatternId] | |
| const route: Route | null = useRoute(selectedRoutePattern?.routeId) | |
| if (!route || selectedRoutePattern === undefined) { | |
| return <></> | |
| } | |
| return ( | |
| <RoutePropertiesCardRender | |
| routePatterns={routePatterns} | |
| route={route} | |
| selectedRoutePattern={selectedRoutePattern} | |
| selectRoutePattern={selectRoutePattern} | |
| onClose={onClose} | |
| /> | |
| ) | |
| } | |
| const RoutePropertiesCardFromPatternId = ({ | |
| routePatterns, | |
| selectedRoutePatternId, | |
| selectRoutePattern, | |
| onClose, | |
| }: { | |
| routePatterns: ByRoutePatternId<RoutePattern> | |
| selectedRoutePatternId: RoutePatternId | |
| selectRoutePattern: (routePattern: RoutePattern) => void | |
| onClose?: () => void | |
| }) => { | |
| const selectedRoutePattern = routePatterns[selectedRoutePatternId] | |
| const route: Route | null = useRoute(selectedRoutePattern?.routeId) | |
| if (!route || selectedRoutePattern === undefined) { | |
| return <></> | |
| } | |
| return ( | |
| <RoutePropertiesCardRender | |
| routePatterns={routePatterns} | |
| route={route} | |
| selectedRoutePattern={selectedRoutePattern} | |
| selectRoutePattern={selectRoutePattern} | |
| onClose={onClose} | |
| /> | |
| ) | |
| } | |
| RoutePropertiesCard.FromPatternId = RoutePropertiesCardFromPatternId |
There was a problem hiding this comment.
@firestack just to make sure I understand your suggestion correctly...
My current naming scheme is to extract the rendery bits into <RoutePropertiesCardRender /> and keep <RoutePropertiesCard /> exactly the same.
Your suggestion is, on top of ☝️:
- Change the name of the old component to
<RoutePropertiesCardFromPatternId /> - Name the new rendery component
<RoutePropertiesCard />
And those are the only changes you're suggesting? (If so, then I like it!)
Just double-checking because Github doesn't do suggestion diffs very well, so ☝️ looks like a huge change!
There was a problem hiding this comment.
Oh hey - it doesn't actually cause a diff with the rest of the app, because of 👇
export default RoutePropertiesCardFromPatternId…Card as its own component
Coverage of commit
|
…Card as its own component
Coverage of commit
|
…Card as its own component
Coverage of commit
|
…Card as its own component
Coverage of commit
|
|
Closed in favor of #2609 Turns out the routes are provided by a context, which makes this a lot easier to do without refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as a draft PR for now because I want to add a storybook story for this.Storybook story added!
Now it's marked as draft because this might not be the best way to accomplish this goal.