You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mbta/skate-developers at the risk of slightly bikeshedding... I started experimenting with atomic design, and put this in the molecules folder, but ... now that I think about it, it's more of an organism?
Summary coverage rate:
lines......: 93.6% (3242 of 3465 lines)
functions..: 73.4% (1341 of 1828 functions)
branches...: no data found
Files changed coverage rate: n/a
Summary coverage rate:
lines......: 93.6% (3242 of 3465 lines)
functions..: 73.4% (1341 of 1828 functions)
branches...: no data found
Files changed coverage rate: n/a
@mbta/skate-developers at the risk of slightly bikeshedding... I started experimenting with atomic design, and put this in the molecules folder, but ... now that I think about it, it's more of an organism?
Whatever term you choose here can completely be reworked in the subsequent atomic design task. And perhaps some a definition guide will be useful when that work is done. Personally, I'd be drawn to terms that fit our context / needs like atom, compound, layoutElement, page. The atomic design terms like organism are great for the analogy / idea, but I wouldn't use it in the final product because they can be interpreted so differently based on context.
The reason will be displayed to describe this comment to others. Learn more.
Oops, I should have nodded to my comment in my approval, but ultimately I think molecule is fine here, and I have some ideas for renaming when we do the rest of the organizational change to storybook
Base automatically changed from
jdl/tests/simplify-rpc-tests to
mainMay 20, 2024 18:47
Whatever term you choose here can completely be reworked in the subsequent atomic design task. And perhaps some a definition guide will be useful when that work is done.
Yeah that's a good point. Maybe for the immediate moment, I'll put it at the top level, and then once we make a Real Decision™, we can move it around.
Personally, I'd be drawn to terms that fit our context / needs like atom, compound, layoutElement, page. The atomic design terms like organism are great for the analogy / idea, but I wouldn't use it in the final product because they can be interpreted so differently based on context.
Huh, I hadn't even thought of straying away from the exact terms in the atomic design doc.... but yeah, we should definitely aim for things that meet our needs and aren't confusing!
Summary coverage rate:
lines......: 93.6% (3242 of 3465 lines)
functions..: 73.4% (1341 of 1828 functions)
branches...: no data found
Files changed coverage rate: n/a
Summary coverage rate:
lines......: 93.6% (3242 of 3465 lines)
functions..: 73.4% (1341 of 1828 functions)
branches...: no data found
Files changed coverage rate: n/a
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joshlarson
force-pushed
the
jdl/stories/story-for-route-properties-card
branch
from
No description provided.