Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.MediaDevices.devicechange_event - Safari Support #8688

Closed
Lytigas opened this issue Jan 8, 2021 · 1 comment · Fixed by #8863
Closed

api.MediaDevices.devicechange_event - Safari Support #8688

Lytigas opened this issue Jan 8, 2021 · 1 comment · Fixed by #8863
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue Good issues for getting started with this project.

Comments

@Lytigas
Copy link
Contributor

Lytigas commented Jan 8, 2021

Safari Version 13.1.2 (15609.3.5.1.3)

What information was incorrect, unhelpful, or incomplete?

Safari support for the devicechange event.

What did you expect to see?

Safari listed as supported in the table.

Did you test this? If so, how?

  1. Open a webpage using device permissions.
  2. Attempt navigator.mediaDevices.addEventListener('devicechange', console.log)
  3. Attach a new device, and observe that the event fires.
MDN page report details
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 8, 2021
@ddbeck ddbeck added the good first issue Good issues for getting started with this project. label Jan 20, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Jan 20, 2021

Thanks for reporting this, @Lytigas. I did a bit of digging and confirmed that this is right; the feature was introduced in Safari 11. This aligns with the data we have for ondevicechange. To correct this, I invite you (or another contributor) to open a pull request to modify the devicechange_event feature in MediaDevices.json. Thanks again!

Lytigas added a commit to Lytigas/browser-compat-data that referenced this issue Jan 26, 2021
@Lytigas
Update Safari support for devicechange_event
0286010 
Per work done by @ddbeck [1], support begins with version 11, aligning with support for `ondevicechange`.

[1] mdn#8688 (comment)
@Lytigas Lytigas mentioned this issue Jan 26, 2021
Merged
ddbeck pushed a commit that referenced this issue Jan 26, 2021
@Lytigas
Update Safari support for devicechange_event (#8863)
3938875 
Per work done by @ddbeck [1], support begins with version 11, aligning with support for `ondevicechange`.

[1] #8688 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API good first issue Good issues for getting started with this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Safari support for devicechange_event Lytigas/browser-compat-data
3 participants
@ddbeck @queengooborg @Lytigas