Demix ElementCSSInlineStyle #10686
Merged
Demix ElementCSSInlineStyle #10686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
commented
May 31, 2021
foolip
commented
May 31, 2021
foolip
commented
May 31, 2021
foolip
commented
May 31, 2021
foolip
commented
May 31, 2021
Elchi3
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Looks good to me.
Not sure where we are with a policy regarding 404 MDN links in BCD. I guess we could remove these...
Also, as a general fyi, mixins are also allowed to appear inline with the interfaces. I've done this sometimes when the mixin is relatively small (like it is here). However, I'm fine with having them in the _mixins folder, too. Just saying :)
|
Let me know if you want to remove the 404 links, otherwise this is good to merge. |
|
I'll prepare the MDN PR for this first to see which of the URLs end up existing again... |
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 1, 2021
Redirect ElementCSSInlineStyle.style to HTMLElement.style, as that's seemingly what many of these instances pointed at originally, and it's the most common case when used in examples/explanations. Of the six pages that should exist here, only HTMLElement.style actually exists. BCD cleanup: mdn/browser-compat-data#10686
|
I've sent mdn/content#5556 and will remove |
Tests used (staging because a test bug was just fixed): http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/HTMLElement http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/MathMLElement http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/SVGElement As a starting point, the existing api.Element.attributeStyleMap and api.HTMLElement.style entries were combined into ElementCSSInlineStyle__HTMLElement.json without modification. MathMLElement data is based on mdn-bcd-collector results from Firefox and Safari desktop. Mobile data was mirrored. The api.MathMLElement parent entry was also updated. Note that there's no api.MathMLElement.attributeStyleMap entry because no browser supports it. SVGElement data is hard to be 100% confident in because it goes back so far. api.SVGElement.style support was confirmed in: - Chrome ≤15 - IE 9 - Firefox ≤4 - Opera ≤12.1 - Safari ≤4 The following were assumed/mirrored: - Chrome 1 / for Android 18 - Edge 12 - Firefox 1.5 / for Android 4 - Opera for Android ≤12.1 - Safari 3 / for iOS 1 - Samsung Internet 1.0 - WebView 1 SVGElement itself was changed to Firefox 1.5 too, as the only SVG-related entry marked as shipped in Firefox 1.
foolip
force-pushed
the
ElementCSSInlineStyle
branch
from
78e2bb4 to
a058d28
Compare
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 7, 2021
Redirect ElementCSSInlineStyle.style to HTMLElement.style, as that's seemingly what many of these instances pointed at originally, and it's the most common case when used in examples/explanations. Of the six pages that should exist here, only HTMLElement.style actually exists. BCD cleanup: mdn/browser-compat-data#10686
foolip
added a commit
to foolip/content
that referenced
this pull request
Jun 7, 2021
Redirect ElementCSSInlineStyle.style to HTMLElement.style, as that's seemingly what many of these instances pointed at originally, and it's the most common case when used in examples/explanations. Of the six pages that should exist here, only HTMLElement.style actually exists. BCD cleanup: mdn/browser-compat-data#10686
|
@Elchi3 I expect mdn/content#5556 will be merged soon, if you'd care to review this. |
|
Oh wait what am I saying, this is already approved. I'll merge it myself when the MDN change is merged, if nobody else does. |
|
mdn/content#5556 was merged. |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jun 9, 2021
ddbeck
added a commit
that referenced
this pull request
Jun 10, 2021
* Bump version to v3.3.7 * Add release note for #10745 * Add release note for #10686 * Add release note for #10744 * Add release note for #10820 * Add release note for #10582 * Add release note for #9464 * Add release note for #10724 * Add release note for #10827 * Add release note for #10829 * Add release note for #10782 * Add stats * Add release date * Update stats one last time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests used (staging because a test bug was just fixed):
http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/HTMLElement
http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/MathMLElement
http://staging-dot-mdn-bcd-collector.appspot.com/tests/api/SVGElement
As a starting point, the existing api.Element.attributeStyleMap and
api.HTMLElement.style entries were combined into
ElementCSSInlineStyle__HTMLElement.json without modification.
MathMLElement data is based on mdn-bcd-collector results from Firefox
and Safari desktop. Mobile data was mirrored. The api.MathMLElement
parent entry was also updated. Note that there's no
api.MathMLElement.attributeStyleMap entry because no browser supports
it.
SVGElement data is hard to be 100% confident in because it goes back so
far. api.SVGElement.style support was confirmed in:
The following were assumed/mirrored:
SVGElement itself was changed to Firefox 1.5 too, as the only
SVG-related entry marked as shipped in Firefox 1.