Demix LinkStyle mixin #10724
Demix LinkStyle mixin #10724
Conversation
github-actions
bot
added
the
data:api
| "HTMLLinkElement": { | ||
| "sheet": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLLinkElement/sheet", |
There was a problem hiding this comment.
This doesn't exist, at least not yet. Will you also prepare a PR for https://github.com/mdn/content that removes all references to LinkStyle, similar to mdn/content#5579? https://github.com/mdn/content#moving-one-or-more-documents might come in handy if so.
There was a problem hiding this comment.
I haven't contributed to the content repository yet, but I'd be happy to write a PR to go along with this one!
There was a problem hiding this comment.
Apparently there's no page for LinkStyle.sheet, so I can't move/copy it. Additionally, there aren't any pages for the sheet property on any of the inheriting APIs. Not really sure what to do on the content repo, would love some assistance!
There was a problem hiding this comment.
I think the main task here is to remove mentions of LinkStyle.sheet. There's no page, but there are references to it. Searching that string should mostly turn up variations on {{domxref("LinkStyle.sheet")}}—there's just a few of them, but you'll need to read it in context to figure out what exactly to cut out (e.g., a <dt>-<dd> pair).
There was a problem hiding this comment.
I've sent mdn/content#5669 to accompany this PR!
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
|
From the review of the mdn/content PR, it's been determined that |
|
https://svgwg.org/svg2-draft/styling.html#InterfaceSVGStyleElement confirms that SVGStyleElement includes this mixin (MDN saying so wasn't enough to convince me). |
|
mdn/content#5669 in the MDN change (posting here to make it easier to find for myself) |
|
I'll go ahead and merge this, betting that mdn/content#5669 is merged by the time the next BCD release rolls into yari. |
|
Making a note here for myself, for the release notes: Removed
Added
|
* Bump version to v3.3.7 * Add release note for #10745 * Add release note for #10686 * Add release note for #10744 * Add release note for #10820 * Add release note for #10582 * Add release note for #9464 * Add release note for #10724 * Add release note for #10827 * Add release note for #10829 * Add release note for #10782 * Add stats * Add release date * Update stats one last time
This PR demixes the
LinkStylemixin and separates it into the individual API files. Its version numbers have been determined by running the mdn-bcd-collector project in various browsers, along with some mirroring in certain cases.Additionally, the member this mixin exposed,
sheet, was included normally on theHTMLStyleElementAPI's data. This PR removes it as to prevent de-duplication (and mitigate a loader crash, see #10734).