Demix Navigator* mixins into Navigator and WorkerNavigator #11413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
queengooborg
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
I have been looking forward to this for quite some time, thank you for taking the initiative @teoli2003! LGTM!
|
A little extra note on this that I forgot to mention: for most of the mixins, we have been keeping them defined within separate files, but moving them to a |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 15, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 15, 2021
* Bump version to v3.3.11 * Add release note for #11502 * Add release note for #11499 * Add release note for #11100 * Add release note for #11101 * Add release note for #11152 * Add release note for #11355 * Add release note for #11361 * Add release note for #11438 * Add release note for #11520 * Add release note for #11452 * Add release note for #11481 * Add second release note for #11481 * Add release note for #11500 * Add release note for #11524 * Add release note for #11413 * Add release note for #11414 * Add release date * Add stats * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to mdn/content#6637
Navigation*.*info to the correspondingNavigation.*entries.WorkerNavigation.*, they are those ofWorkerNavigation. I set some values totruebecauseWorkerNavigationwas set totrueand it is probably a feature as old as it. They will be fixed at the same time (when we test forWorkerNavigation, we will test for the subfeatures too).Navigation*.jsonfiles.