Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold api.FullscreenOptions into api.Element.requestFullscreen #11481

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jul 12, 2021

The options_parameter entry by itself doesn't represent anything useful,
and navigationUI is the only dictionary member, so let the entry
represent that.

The options_parameter entry by itself doesn't represent anything useful,
and navigationUI is the only dictionary member, so let the entry
represent that.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 12, 2021
@foolip foolip force-pushed the FullscreenOptions branch from 76941a7 to eb7950b Compare July 12, 2021 10:06
@foolip foolip added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 12, 2021
@foolip
Copy link
Contributor Author

foolip commented Jul 12, 2021

I am not planning to send the mdn/content PR myself right now. If this gets reviewed and is blocked by that I will, but sometimes someone volunteers to do it, so holding out hope for that :)

@Elchi3
Copy link
Member

Elchi3 commented Jul 13, 2021

I enjoy being that volunteer: mdn/content#6852

@foolip
Copy link
Contributor Author

foolip commented Jul 13, 2021

Thanks @Elchi3!

@Elchi3 Elchi3 removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 13, 2021
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content PR was merged

@Elchi3 Elchi3 merged commit 569c156 into mdn:main Jul 13, 2021
@foolip foolip deleted the FullscreenOptions branch July 13, 2021 14:21
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 15, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 15, 2021
ddbeck added a commit that referenced this pull request Jul 15, 2021
* Bump version to v3.3.11

* Add release note for #11502

* Add release note for #11499

* Add release note for #11100

* Add release note for #11101

* Add release note for #11152

* Add release note for #11355

* Add release note for #11361

* Add release note for #11438

* Add release note for #11520

* Add release note for #11452

* Add release note for #11481

* Add second release note for #11481

* Add release note for #11500

* Add release note for #11524

* Add release note for #11413

* Add release note for #11414

* Add release date

* Add stats

* Fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants