Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF101 RTCRtpEncodingParameters.maxFramerate supported #16200

Merged

Conversation

hamishwillee
Copy link
Contributor

@hamishwillee hamishwillee commented May 10, 2022

FF101 supports RTCRtpEncodingParameters.maxFramerate - added by https://bugzilla.mozilla.org/show_bug.cgi?id=1611957

This is blocked because the WebRTC Extensions spec is not in W3C. I've created a PR for that, but I really don't know what I'm doing, so help/update appreciated: w3c/browser-specs#605.

@queengooborg Are you planning on merging in the RTCRtpEncodingParameters dictionary (i.e. we don't do dictionaries any more "as a rule"? I ask because this is an update to it and I'm not clear whether this is one of the few dictionaries we decided to keep, or just hasn't been addressed yet. Either way, I'll make this update first, and any structural fixes can come as a post-process.

Other docs work for this can be tracked in mdn/content#15470

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 10, 2022
@queengooborg
Copy link
Contributor

Are you planning on merging in the RTCRtpEncodingParameters dictionary (i.e. we don't do dictionaries any more "as a rule"?

Thanks for asking! Yes, we're working to get rid of all dictionaries from BCD, but since the RTC's dictionaries have a lot of details not researched in BCD, we haven't been able to remove them just yet. Updates to them in the meantime are a-okay. 👍

@queengooborg
Copy link
Contributor

It looks like the spec URLs aren't added to browser-specs, probably due to the fact that the "current version" link on the page is broken. Could you add this to the exceptions list in spec-urls.test.js?

@github-actions github-actions bot added the linter Issues or pull requests regarding the tests / linter of the JSON files. label May 10, 2022
@hamishwillee
Copy link
Contributor Author

hamishwillee commented May 10, 2022

Thanks @queengooborg - I'd forgotten that's how you add exceptions. Not sure I've done it before. Merge at will :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API linter Issues or pull requests regarding the tests / linter of the JSON files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants