RTCRtpEncodingParameters.maxFramerate - off spec zero value #16272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
|
@queengooborg When you have a moment :-) |
7 tasks
github-actions
bot
added
the
linter
hamishwillee
commented
May 17, 2022
| @@ -54,7 +54,7 @@ describe('spec_url data', () => { | |||
| // Remove if it is in the main ECMA spec | |||
| 'https://tc39.es/proposal-hashbang/out.html', | |||
|
|
|||
| // Remove if https://github.com/w3c/browser-specs/pull/605 is merged | |||
| // Remove if https://github.com/w3c/webrtc-extensions/issues/108 is closed | |||
There was a problem hiding this comment.
FYI what will happen here is that the parameter will move to the supported spec. So when that changes we'd remove the exception and change the spec.
|
@queengooborg Can you please review this when you have a chance. |
queengooborg
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF101 added support for RTCRtpEncodingParameters.maxFramerate, which we updated in #16200
This is supposed to be valid for a 0 value, but FF instead sets this as "no limit on frame rate". This is because the upstream libwebrtc library used will crash if a 0 value is passed (see https://bugzilla.mozilla.org/show_bug.cgi?id=1611957#c10)
To fix this I have marked the API as "partial" and added a note.
Related docs work can be tracked in mdn/content#15470