Update Chromium versions for CSSTransition API #18570
Conversation
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the `CSSTransition` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.gooborg.com) project (v7.1.3). Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CSSTransition _Check out the [collector's guide on how to review this PR](https://github.com/GooborgStudios/mdn-bcd-collector#reviewing-bcd-changes)._ --- This data was originally set to "78" in mdn#6372. This data had come from reading through the IDL and using commit history to determine when the feature was implemented (see mdn#6372 (comment)). Since Edge was set to "84" in mdn#9190, it makes less sense to keep Chrome at "78".
queengooborg
added
the
data:api
There was a problem hiding this comment.
It's unclear to me where 84 comes from.
I think 78 is still the best and proofed version number https://storage.googleapis.com/chromium-find-releases-static/d69.html#d692c061c5a4f07611af04d53a032c8ac4dde7c5
|
It's weird that Edge and Chrome do not agree currently. I did a bit of research and found the following: The CSSTransition IDL was added to Chromium in 78: https://chromiumdash.appspot.com/commit/d692c061c5a4f07611af04d53a032c8ac4dde7c5 But it seems to be part of the larger WebAnimations implementation in Chromium which got enabled in 84: If I'm understanding this correctly, the correct version here should be 84 for both chrome and edge. |
There was a problem hiding this comment.
But it seems to be part of the larger WebAnimations implementation in Chromium which got enabled in 84:
https://chromiumdash.appspot.com/commit/9cdcb106b0bcfee75cf3e94576fd48c055cc4bd6
(tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=978551)
Thanks, this was the missing information here.
|
Thanks @captainbrosset! And thanks @Elchi3 for approving! |
This PR updates and corrects version values for Chromium (Chrome, Opera, Samsung Internet, WebView Android) for the
CSSTransitionAPI, based upon results from the mdn-bcd-collector project (v7.1.3).Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CSSTransition
Check out the collector's guide on how to review this PR.
This data was originally set to "78" in #6372. This data had come from reading through the IDL and using commit history to determine when the feature was implemented (see #6372 (comment)). Since Edge was set to "84" in #9190, it makes less sense to keep Chrome at "78".