Update Chrome/Safari data for image-set() #22912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:css
The history of this feature is complicated, with a long history of prefixed support and recent extened syntax which should also work with the prefixed form because it's defined as an alias: https://drafts.csswg.org/css-images-4/#deprecated This would be nicer with mdn#17857 but for now this results in split entries with duplicated notes. The details: -webkit-image-set() was implementated in WebKit 536.4 for Safari: WebKit/WebKit@63ee6e4 https://github.com/WebKit/WebKit/blob/63ee6e4e5f867a55faedef4a7f02fb1b9775dd7b/Source/WebCore/Configurations/Version.xcconfig It was enabled in WebKit 536.8 for Chromium: WebKit/WebKit@68a3754 https://github.com/WebKit/WebKit/blob/68a3754b19f8e92fabfc263b17baad33a895bd35/Source/WebCore/Configurations/Version.xcconfig That maps to Safari 6 and Chrome 20. The data previously said Chrome 21, so Chrome 20 was confirmed in BrowserStack using this test: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=12632 image-set() was unprefixed in WebKit 603.1.11 (Safari 10.1): WebKit/WebKit@ea622e8 https://github.com/WebKit/WebKit/blob/ea622e8b67a6bc11cc45d1d34953ac795df4dfb3/Source/WebCore/Configurations/Version.xcconfig The extended syntax was added in WebKit 610.1.1 (Safari 14): WebKit/WebKit@5269267 https://github.com/WebKit/WebKit/blob/52692677632e50f8d0e3a4b0f62c94e5520a47d9/Source/WebCore/Configurations/Version.xcconfig
foolip
force-pushed
the
webkit-image-set
branch
from
f7f7e3a to
57bb099
Compare
ddbeck
approved these changes
Apr 24, 2024
| "version_added": "20", | ||
| "version_removed": "113", | ||
| "partial_implementation": true, | ||
| "notes": "Support for <code>url</code> images only and <code>x</code> is the only supported resolution unit." |
There was a problem hiding this comment.
I nearly suggested rewriting this note wholesale, but then I saw that you're copying an existing one. Letting it stand for consistency. 😄
There was a problem hiding this comment.
Feel free to rewrite them all in a separate PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The history of this feature is complicated, with a long history of
prefixed support and recent extened syntax which should also work with
the prefixed form because it's defined as an alias:
https://drafts.csswg.org/css-images-4/#deprecated
This would be nicer with #17857
but for now this results in split entries with duplicated notes.
The details:
-webkit-image-set() was implementated in WebKit 536.4 for Safari:
WebKit/WebKit@63ee6e4
https://github.com/WebKit/WebKit/blob/63ee6e4e5f867a55faedef4a7f02fb1b9775dd7b/Source/WebCore/Configurations/Version.xcconfig
It was enabled in WebKit 536.8 for Chromium:
WebKit/WebKit@68a3754
https://github.com/WebKit/WebKit/blob/68a3754b19f8e92fabfc263b17baad33a895bd35/Source/WebCore/Configurations/Version.xcconfig
That maps to Safari 6 and Chrome 20. The data previously said Chrome 21,
so Chrome 20 was confirmed in BrowserStack using this test:
https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=12632
image-set() was unprefixed in WebKit 603.1.11 (Safari 10.1):
WebKit/WebKit@ea622e8
https://github.com/WebKit/WebKit/blob/ea622e8b67a6bc11cc45d1d34953ac795df4dfb3/Source/WebCore/Configurations/Version.xcconfig
The extended syntax was added in WebKit 610.1.1 (Safari 14):
WebKit/WebKit@5269267
https://github.com/WebKit/WebKit/blob/52692677632e50f8d0e3a4b0f62c94e5520a47d9/Source/WebCore/Configurations/Version.xcconfig