-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image-set.dist.yml #928
Conversation
safari: "14" | ||
safari_ios: "14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caniuse says this is partial until 17. I see you did not reflect that change in the BCD PR. For posterity, want to make a note about what you're thinking here?
(marking approved because I'm presuming reasonableness and I mostly want something to look back on in case anyone asks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, looks like more BCD updates will be needed here to be consistent between Firefox and Safari regarding support for type()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddbeck can you review mdn/browser-compat-data#22902 and mdn/browser-compat-data#22912? I'll need to build on those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foolip Approved and merged the Chrome/Safari PR, but I had questions on the Firefox one. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent mdn/browser-compat-data#22939 and will change to Safari 17 here.
The Baseline low date is from Safari 17.
The Baseline low date is from Safari 17.