Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-set.dist.yml #928

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 22, 2024

The Baseline low date is from Safari 17.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 22, 2024
@foolip foolip mentioned this pull request Apr 22, 2024
32 tasks
Comment on lines 17 to 18
safari: "14"
safari_ios: "14"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caniuse says this is partial until 17. I see you did not reflect that change in the BCD PR. For posterity, want to make a note about what you're thinking here?

(marking approved because I'm presuming reasonableness and I mostly want something to look back on in case anyone asks)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, looks like more BCD updates will be needed here to be consistent between Firefox and Safari regarding support for type().

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddbeck can you review mdn/browser-compat-data#22902 and mdn/browser-compat-data#22912? I'll need to build on those.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip Approved and merged the Chrome/Safari PR, but I had questions on the Firefox one. Thank you!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've sent mdn/browser-compat-data#22939 and will change to Safari 17 here.

@foolip foolip mentioned this pull request Apr 24, 2024
The Baseline low date is from Safari 17.
@foolip foolip requested a review from ddbeck April 25, 2024 07:12
@foolip foolip merged commit 57ad8a7 into web-platform-dx:main Apr 25, 2024
3 checks passed
@foolip foolip deleted the dist-image-set branch April 25, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants