Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser support info for innerHTML #2717

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Sep 4, 2018

Basically it's the minimum version of each browser, except:

  • Internet Explorer 4 (reference: [1])
  • Opera 7 (references : [1], [2], [3])
  • Couldn't confirm the exact version with 100% certainty for Opera Mobile and Safari, so I left them out

@vlakoff
Copy link
Contributor Author

vlakoff commented Sep 4, 2018

Removed version for WebView, as I'm not sure what is the first version of WebView.

},
"safari": {
"version_added": null
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Safari for iOS supported this from the start, the same therefore applies to desktop Safari, therefore this should probably be "1".

Copy link
Contributor Author

@vlakoff vlakoff Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure yet: iPhone OS 1 has been released on June 2008, whereas Safari 1 has been released on June 2003.

For perspective, Opera 7, the first Opera version to support innerHTML, has been released on January 2003.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Safari for iOS was released with the iPhone in 2007 when it was still called "iPhone OS", it's hard to really determine what the version numbers should be for early versions, but I'm pretty sure it shouldn't be "1".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with true for now.

api/Element.json Outdated
@@ -1964,43 +1964,43 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/innerHTML",
"support": {
"webview_android": {
"version_added": null
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort this alphabetically (#1882/#398), and see issue #2690.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but TBH I don't get the point of taking care of this in this PR.

It's unrelated and add noise.
And doesn't it introduce more merge conflicts than it solves?

Please don't discuss about it here, to not introduce even more noise.

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 4, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@Elchi3 Elchi3 merged commit 29820d4 into mdn:master Sep 6, 2018
@vlakoff vlakoff deleted the innerHTML branch September 6, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants