-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser support info for innerHTML #2717
Conversation
Removed version for WebView, as I'm not sure what is the first version of WebView. |
}, | ||
"safari": { | ||
"version_added": null | ||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Safari for iOS supported this from the start, the same therefore applies to desktop Safari, therefore this should probably be "1"
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure yet: iPhone OS 1 has been released on June 2008, whereas Safari 1 has been released on June 2003.
For perspective, Opera 7, the first Opera version to support innerHTML, has been released on January 2003.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Safari for iOS was released with the iPhone in 2007 when it was still called "iPhone OS", it's hard to really determine what the version numbers should be for early versions, but I'm pretty sure it shouldn't be "1".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go with true for now.
api/Element.json
Outdated
@@ -1964,43 +1964,43 @@ | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/innerHTML", | |||
"support": { | |||
"webview_android": { | |||
"version_added": null | |||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but TBH I don't get the point of taking care of this in this PR.
It's unrelated and add noise.
And doesn't it introduce more merge conflicts than it solves?
Please don't discuss about it here, to not introduce even more noise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
Basically it's the minimum version of each browser, except: