Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser support info for innerHTML #2717

Merged
merged 2 commits into from
Sep 6, 2018
Merged

Add browser support info for innerHTML #2717

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beeefe2
Add browser support info for innerHTML
vlakoff Sep 4, 2018
9f0402d
Alphabetical ordering for browsers of edited section
vlakoff Sep 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions api/Element.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1964,43 +1964,43 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/innerHTML",
"support": {
"webview_android": {
"version_added": null
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sort this alphabetically (#1882/#398), and see issue #2690.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but TBH I don't get the point of taking care of this in this PR.

It's unrelated and add noise.
And doesn't it introduce more merge conflicts than it solves?

Please don't discuss about it here, to not introduce even more noise.

},
"chrome": {
"version_added": null
"version_added": "1"
},
"chrome_android": {
"version_added": null
"version_added": "18"
},
"edge": {
"version_added": null
"version_added": "12"
},
"edge_mobile": {
"version_added": null
"version_added": "12"
},
"firefox": {
"version_added": null
"version_added": "1"
},
"firefox_android": {
"version_added": null
"version_added": "4"
},
"ie": {
"version_added": null
"version_added": "4"
},
"opera": {
"version_added": null
"version_added": "7"
},
"opera_android": {
"version_added": null
"version_added": true
},
"safari": {
"version_added": null
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Safari for iOS supported this from the start, the same therefore applies to desktop Safari, therefore this should probably be "1".

Copy link
Contributor Author

@vlakoff vlakoff Sep 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure yet: iPhone OS 1 has been released on June 2008, whereas Safari 1 has been released on June 2003.

For perspective, Opera 7, the first Opera version to support innerHTML, has been released on January 2003.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because Safari for iOS was released with the iPhone in 2007 when it was still called "iPhone OS", it's hard to really determine what the version numbers should be for early versions, but I'm pretty sure it shouldn't be "1".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with true for now.

},
"safari_ios": {
"version_added": null
"version_added": "1"
},
"samsunginternet_android": {
"version_added": null
"version_added": "1.0"
}
},
"status": {
Expand Down