Fix AmbientLightSensor+Magnetometer API data #6699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
queengooborg
changed the title
foolip
reviewed
Sep 17, 2020
| } | ||
| ], | ||
| "chrome": { | ||
| "version_added": "56" |
There was a problem hiding this comment.
Unfortunately this will also run into #6509. 😢
There was a problem hiding this comment.
I think this is fine to merge as it is before coming to a decision in #6509? This PR doesn't change the status of flag data inclusion in the subfeatures, which we'd need to check in every file with flags anyways.
There was a problem hiding this comment.
Well, I guess so. This is a case that will be caught by any migration script, as the parent feature has flags but this does not.
foolip
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all of the data for the
AmbientLightSensorAPI. When running results from the mdn-bcd-collector project, I noticed that it was reporting that the API was not supported in Chrome. Doing some digging around, it looks like the data was added very, very incorrectly.First off, the
AmbientLightSensorAPI had always been based upon the Generic Sensor API since it was first implemented. Second, neither API was exposed by default -- the #enable-generic-sensor flag needed to be enabled (and then later, the #enable-generic-sensor-extra-classes as well).This data was determined by testing for
'AmbientLightSensor' in self;and'Magnetometer' in self;in BrowserStack in various Chrome versions with different flags.