Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AmbientLightSensor+Magnetometer API data #6699

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Fix AmbientLightSensor+Magnetometer API data #6699

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b728ae
Fix AmbientLightSensor API data
queengooborg Sep 15, 2020
3b85ca5
Add Magnetometer data
queengooborg Sep 15, 2020
7c9916a
Simplify flag data by using Experimental Web Platform Features flag
queengooborg Sep 17, 2020
5c1896e
Fix Opera Android version
queengooborg Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
268 changes: 150 additions & 118 deletions api/AmbientLightSensor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,24 +6,74 @@
"support": {
"chrome": [
{
"version_added": "54"
"version_added": "62",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
},
{
"type": "preference",
"name": "#enable-generic-sensor-extra-classes",
"value_to_set": "Enabled"
}
]
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
"version_added": "56",
"version_removed": "62",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
}
]
}
],
"chrome_android": [
{
"version_added": "54"
"version_added": "62",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
},
{
"type": "preference",
"name": "#enable-generic-sensor-extra-classes",
"value_to_set": "Enabled"
}
]
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
"version_added": "56",
"version_removed": "62",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
}
]
}
],
"edge": {
"version_added": "≤79"
"version_added": "79",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
},
{
"type": "preference",
"name": "#enable-generic-sensor-extra-classes",
"value_to_set": "Enabled"
}
]
},
"firefox": {
"version_added": false
Expand All @@ -34,36 +84,74 @@
"ie": {
"version_added": false
},
"opera": {
"version_added": "56"
},
"opera_android": {
"version_added": "48"
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": [
"opera": [
{
"version_added": "6.0"
"version_added": "49",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
},
{
"type": "preference",
"name": "#enable-generic-sensor-extra-classes",
"value_to_set": "Enabled"
}
]
},
{
"version_added": "10.0",
"notes": "Based on Generic Sensor API."
"version_added": "43",
"version_removed": "49",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
}
]
}
],
"webview_android": [
"opera_android": [
{
"version_added": "54"
"version_added": "46",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
},
{
"type": "preference",
"name": "#enable-generic-sensor-extra-classes",
"value_to_set": "Enabled"
}
]
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
"version_added": "43",
"version_removed": "46",
"flags": [
{
"type": "preference",
"name": "#enable-generic-sensor",
"value_to_set": "Enabled"
}
]
}
]
],
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
Expand All @@ -76,26 +164,14 @@
"description": "<code>AmbientLightSensor()</code> constructor",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/AmbientLightSensor/AmbientLightSensor",
"support": {
"chrome": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
}
],
"chrome_android": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
}
],
"chrome": {
"version_added": "56"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this will also run into #6509. 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge as it is before coming to a decision in #6509? This PR doesn't change the status of flag data inclusion in the subfeatures, which we'd need to check in every file with flags anyways.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess so. This is a case that will be caught by any migration script, as the parent feature has flags but this does not.

},
"chrome_android": {
"version_added": "56"
},
"edge": {
"version_added": "≤79"
"version_added": "79"
},
"firefox": {
"version_added": false
Expand All @@ -107,35 +183,23 @@
"version_added": false
},
"opera": {
"version_added": "56"
"version_added": "43"
},
"opera_android": {
"version_added": "48"
"version_added": "43"
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": [
{
"version_added": "6.0"
},
{
"version_added": "10.0",
"notes": "Based on Generic Sensor API."
}
],
"webview_android": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
}
]
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
Expand All @@ -148,34 +212,16 @@
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/AmbientLightSensor/illuminance",
"support": {
"chrome": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
},
{
"version_added": "79",
"notes": "Stopped returning floats and returned integers avoid fingerprinting."
}
],
"chrome_android": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
},
{
"version_added": "79",
"notes": "Stopped returning floats and returned integers avoid fingerprinting."
}
],
"chrome": {
"version_added": "56",
"notes": "In Chrome 79, this method stopped returning floats and returned integers to avoid fingerprinting."
},
"chrome_android": {
"version_added": "56",
"notes": "In Chrome for Android 79, this method stopped returning floats and returned integers to avoid fingerprinting."
},
"edge": {
"version_added": "≤79"
"version_added": "79"
},
"firefox": {
"version_added": false
Expand All @@ -187,39 +233,25 @@
"version_added": false
},
"opera": {
"version_added": "56"
"version_added": "43",
"notes": "In Opera 66, this method stopped returning floats and returned integers to avoid fingerprinting."
},
"opera_android": {
"version_added": "48"
"version_added": "48",
"notes": "In Opera for Android 57, this method stopped returning floats and returned integers to avoid fingerprinting."
},
"safari": {
"version_added": false
},
"safari_ios": {
"version_added": false
},
"samsunginternet_android": [
{
"version_added": "6.0"
},
{
"version_added": "10.0",
"notes": "Based on Generic Sensor API."
}
],
"webview_android": [
{
"version_added": "54"
},
{
"version_added": "69",
"notes": "Based on Generic Sensor API."
},
{
"version_added": "79",
"notes": "Stopped returning floats and returned integers avoid fingerprinting."
}
]
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
Expand Down
Loading