-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aspect-ratio CSS property #6903
Conversation
Removing details of internal mapping and adding support only for property.
The |
@rachelandrew I've opened #6918 to relocate the HTML data. If you restore the |
@ddbeck sorry I don't understand what the end result is that you want. If you just want it put back then we can close this PR and start over? |
css/properties/aspect-ratio.json
Outdated
"standard_track": true, | ||
"deprecated": false | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Rachel. I should've been more clear about what I was asking for. I'd like you to undo the changes from this line down. In other words, leave the internal-value
feature in the file (which will be removed in my PR), but keep the changes from above this line.
@ddbeck hopefully what I've done is right, also added the note about the implementation of support for flex items in Firefox 83. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One consistency suggestion here, but otherwise this looks really good. Thank you, @rachelandrew!
Co-authored-by: Daniel D. Beck <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
To get the tests to pass (and to fix my earlier mistake of asking you to remove the subfeature removal), I'm going to push a merge from master into this branch, so it can appear in today's release. 🚀
Travis is stuck again. Merging without it. |
Removing details of internal mapping and adding support only for property.
As discussed in #6786 this PR removes details of the internal mapping to HTML width and height, and instead adds the support for the property. Partial support behind a flag in Firefox, and support behind a flag in Chrome.