Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aspect-ratio CSS property #6903

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Conversation

rachelandrew
Copy link
Collaborator

Removing details of internal mapping and adding support only for property.

As discussed in #6786 this PR removes details of the internal mapping to HTML width and height, and instead adds the support for the property. Partial support behind a flag in Firefox, and support behind a flag in Chrome.

Removing details of internal mapping and adding support only for property.
@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Oct 13, 2020
@ddbeck ddbeck self-assigned this Oct 13, 2020
@ddbeck ddbeck self-requested a review October 13, 2020 16:17
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 13, 2020

The internal-value feature ought to be replaced in the same PR as one that fixes #6786 (to ensure it's all fixed at once and reflected in the release notes). I'll open a complementary PR for this soon.

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 14, 2020

@rachelandrew I've opened #6918 to relocate the HTML data. If you restore the internal-value data in this PR, then I can track the move for the release notes a little more gracefully. Alternatively, I've requested your review on that PR—if we merge that one first, you can rebase this PR on top of it.

@rachelandrew
Copy link
Collaborator Author

@ddbeck sorry I don't understand what the end result is that you want. If you just want it put back then we can close this PR and start over?

"standard_track": true,
"deprecated": false
}
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Rachel. I should've been more clear about what I was asking for. I'd like you to undo the changes from this line down. In other words, leave the internal-value feature in the file (which will be removed in my PR), but keep the changes from above this line.

@rachelandrew
Copy link
Collaborator Author

@ddbeck hopefully what I've done is right, also added the note about the implementation of support for flex items in Firefox 83.

@ddbeck ddbeck self-requested a review October 27, 2020 14:43
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One consistency suggestion here, but otherwise this looks really good. Thank you, @rachelandrew!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

To get the tests to pass (and to fix my earlier mistake of asking you to remove the subfeature removal), I'm going to push a merge from master into this branch, so it can appear in today's release. 🚀

@ddbeck
Copy link
Collaborator

ddbeck commented Oct 29, 2020

Travis is stuck again. Merging without it.

@ddbeck ddbeck merged commit 8321f08 into mdn:master Oct 29, 2020
@ddbeck ddbeck changed the title update aspect ratio Update aspect-ratio CSS property Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants