Skip to content

Commit

Permalink
XRLightProbe: Use a single event page (#10373)
Browse files Browse the repository at this point in the history
  • Loading branch information
Elchi3 authored Nov 9, 2021
1 parent ae43c62 commit c7085e3
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 52 deletions.
1 change: 1 addition & 0 deletions files/en-us/_redirects.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9067,6 +9067,7 @@
/en-US/docs/Web/API/XRInputSourcesChangeEventInit/added /en-US/docs/Web/API/XRInputSourcesChangeEvent/XRInputSourcesChangeEvent
/en-US/docs/Web/API/XRInputSourcesChangeEventInit/removed /en-US/docs/Web/API/XRInputSourcesChangeEvent/XRInputSourcesChangeEvent
/en-US/docs/Web/API/XRInputSourcesChangeEventInit/session /en-US/docs/Web/API/XRInputSourcesChangeEvent/XRInputSourcesChangeEvent
/en-US/docs/Web/API/XRLightProbe/onreflectionchange /en-US/docs/Web/API/XRLightProbe/reflectionchange_event
/en-US/docs/Web/API/XRReferenceSpaceEventInit /en-US/docs/Web/API/XRReferenceSpaceEvent/XRReferenceSpaceEvent
/en-US/docs/Web/API/XRReferenceSpaceEventInit/referenceSpace /en-US/docs/Web/API/XRReferenceSpaceEvent/XRReferenceSpaceEvent
/en-US/docs/Web/API/XRReferenceSpaceEventInit/transform /en-US/docs/Web/API/XRReferenceSpaceEvent/XRReferenceSpaceEvent
Expand Down
2 changes: 1 addition & 1 deletion files/en-us/web/api/xrlightprobe/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This object doesn't itself contain lighting values, but it is used to collect li

## Properties

- {{domxref("XRLightProbe.onreflectionchange")}}
- `XRLightProbe.onreflectionchange`
- : Event handler property for the {{domxref("XRLightProbe.reflectionchange_event", "reflectionchange")}} event.
- {{domxref("XRLightProbe.probeSpace")}} {{ReadOnlyInline}}
- : An {{domxref("XRSpace")}} tracking the position and orientation the lighting estimations are relative to.
Expand Down
49 changes: 0 additions & 49 deletions files/en-us/web/api/xrlightprobe/onreflectionchange/index.md

This file was deleted.

17 changes: 15 additions & 2 deletions files/en-us/web/api/xrlightprobe/reflectionchange_event/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,16 @@ The WebXR **`reflectionchange`** event is passed to an {{domxref("XRLightProbe")
</tr>
<tr>
<th>Event handler property</th>
<td>{{domxref("XRLightProbe.onreflectionchange", "onreflectionchange")}}</td>
<td><code>onreflectionchange</code></td>
</tr>
</tbody>
</table>


## Examples

### Using the `reflectionchange` event

Whenever the `reflectionchange` event fires on a light probe, you can retrieve an updated cube map by calling {{domxref("XRWebGLBinding.getReflectionCubeMap()")}}. This is less expensive than retrieving lighting information with every {{domxref("XRFrame")}}.

```js
Expand All @@ -49,6 +51,18 @@ lightProbe.addEventListener('reflectionchange', () => {
});
```

### The `onreflectionchange` event handler property

The `reflectionchange` event is also available using the `onreflectionchange` event handler property.

```js
const glBinding = new XRWebGLBinding(xrSession, gl);

lightProbe.onreflectionchange = event => {
glCubeMap = glBinding.getReflectionCubeMap(lightProbe);
});
```

## Specifications

{{Specifications}}
Expand All @@ -60,4 +74,3 @@ lightProbe.addEventListener('reflectionchange', () => {
## See also

- {{domxref("EventTarget.addEventListener", "addEventListener()")}}
- {{domxref("XRLightProbe.onreflectionchange")}}

0 comments on commit c7085e3

Please sign in to comment.