Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminology for a returned object with properties #9745

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fix terminology for a returned object with properties #9745

merged 1 commit into from
Oct 12, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Oct 12, 2021

Avoid the terms dictionary, member and option. This is just an object with properties.

Also remove the secure context annotations, since the API itself already has this annotation.

@foolip
Fix terminology for a returned object with properties
293f802 
Avoid the terms dictionary, member and option. This is just an object with properties.

Also remove the secure context annotations, since the API itself already has this annotation.
@foolip foolip requested a review from a team as a code owner October 12, 2021 07:47
@foolip foolip requested review from jpmedley and removed request for a team October 12, 2021 07:47
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 12, 2021
@foolip
Copy link
Contributor Author

foolip commented Oct 12, 2021

@hamishwillee @queengooborg I spotted this in #9718, sending this to see if we can align on terminology for future PRs.

@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/StorageManager/estimate
Title: StorageManager.estimate()
on GitHub

No new external URLs

queengooborg
queengooborg approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! I like the sound of the updated wording!

@queengooborg queengooborg merged commit 2d5bd77 into mdn:main Oct 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foolip @queengooborg