fix(a11y): fix tab order reset in the header #9851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tabbing through the header reaching the search input and pressing tab again will reset the focus to the html document. This happened because the next item would be the cancel input button. Which will be removed via display one and then we start from the the beginning.
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tabbing across the search box.
Problem
When tabbing through the header reaching the search input and pressing tab again will reset the focus to the html document.
This happened because the next item would be the cancel input button. Which will be removed via display one and then we start from the the beginning.
Solution
Keep the search box expanding when the parent has focus within.
How did you test this change?
Locally.