Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): fix tab order reset in the header #9851

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions client/src/ui/molecules/search/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@
}
}

.search-widget:focus-within .search-input-field,
.search-input-field:focus,
.search-input-field:valid {
width: inherit;

/* When the search input has focus or has content,
show the clear search button */
~ .button.clear-search-button {
display: block;
right: 2.8rem;
}
}

.search-input-field {
// make webkit play nice with search input types
-webkit-appearance: none; /* stylelint-disable-line property-no-vendor-prefix */
Expand Down Expand Up @@ -48,18 +61,6 @@
}
}

&:focus,
&:valid {
width: inherit;

/* When the search input has focus or has content,
show the clear search button */
~ .button.clear-search-button {
display: block;
right: 2.8rem;
}
}

&:invalid,
&:invalid::placeholder {
animation: blink 2s step-end infinite;
Expand Down