fix(medusa): plus sign to space (#8454)

medusajs · Aug 6, 2024 · 8700896 · 8700896
1 parent 0ec1d98
commit 8700896
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/integration-tests/http/__tests__/product/admin/product.spec.ts b/integration-tests/http/__tests__/product/admin/product.spec.ts
@@ -1081,7 +1081,7 @@ medusaIntegrationTestRunner({
 
           const variants = (
             await api.get(
-              `/admin/products/${product.id}/variants?fields=%2Binventory_quantity`,
+              `/admin/products/${product.id}/variants?fields=+inventory_quantity`,
               adminHeaders
             )
           ).data.variants

diff --git a/integration-tests/modules/__tests__/order/order.spec.ts b/integration-tests/modules/__tests__/order/order.spec.ts
@@ -126,7 +126,7 @@ medusaIntegrationTestRunner({
         const response = await api.get(
           "/admin/orders/" +
             created.id +
-            "?fields=%2Braw_total,%2Braw_subtotal,%2Braw_discount_total",
+            "?fields=+raw_total,+raw_subtotal,+raw_discount_total",
           adminHeaders
         )
 

diff --git a/packages/medusa/src/utils/get-query-config.ts b/packages/medusa/src/utils/get-query-config.ts
@@ -1,3 +1,4 @@
+import { RequestQueryFields } from "@medusajs/types"
 import {
   getSetDifference,
   isDefined,
@@ -6,7 +7,6 @@ import {
   stringToSelectRelationObject,
 } from "@medusajs/utils"
 import { pick } from "lodash"
-import { RequestQueryFields } from "@medusajs/types"
 import { FindConfig, QueryConfig } from "../types/common"
 
 export function pickByConfig<TModel>(
@@ -60,15 +60,17 @@ export function prepareListQuery<T extends RequestQueryFields, TEntity>(
         return !(
           field.startsWith("-") ||
           field.startsWith("+") ||
+          field.startsWith(" ") ||
           field.startsWith("*")
         )
       })
+
     if (shouldReplaceDefaultFields) {
-      allFields = new Set(customFields.map((f) => f.replace(/^[+-]/, "")))
+      allFields = new Set(customFields.map((f) => f.replace(/^[+ -]/, "")))
     } else {
       customFields.forEach((field) => {
-        if (field.startsWith("+")) {
-          allFields.add(field.replace(/^\+/, ""))
+        if (field.startsWith("+") || field.startsWith(" ")) {
+          allFields.add(field.trim().replace(/^\+/, ""))
         } else if (field.startsWith("-")) {
           allFields.delete(field.replace(/^-/, ""))
         } else {