Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(medusa): plus sign to space #8454

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix(medusa): plus sign to space #8454

merged 2 commits into from
Aug 6, 2024
+8 −6

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

Http clients will transform + in the URL to %20 (space)

@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner August 5, 2024 13:50
@vercel Vercel
Copy link

vercel bot commented Aug 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 1:51pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Aug 5, 2024 1:51pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 1:51pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 1:51pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 1:51pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 1:51pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 1:51pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5658a0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

riqwan
riqwan approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

olivermrbl
olivermrbl approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perhaps we need to rethink the + sign some day, but I think we can leave that for when/if we see people getting issues with it

@olivermrbl olivermrbl merged commit 8700896 into develop Aug 6, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/get-query-plus-sign branch August 6, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan

@olivermrbl olivermrbl

@sradevski sradevski

@adrien2p adrien2p

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlos-r-l-rodrigues @riqwan @olivermrbl