Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product categories hooks #11093

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

noubase
Copy link
Contributor

@noubase noubase commented Jan 22, 2025

There are three hooks for the basic product categories workflows.

@noubase noubase requested a review from a team as a code owner January 22, 2025 15:55
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 0a2a628

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 22, 2025

@noubase is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@sradevski
Copy link
Member

@noubase the tests (the build actually) is failing, can you please look into it?

@noubase noubase force-pushed the feat/product-category-hooks branch 2 times, most recently from 2060542 to 69f5eec Compare January 23, 2025 11:48
@noubase
Copy link
Contributor Author

noubase commented Jan 23, 2025

@noubase the tests (the build actually) is failing, can you please look into it?

Fixed. WorkflowResponse type generics it's a nightmare. No wonder no one from a core team is using it

@sradevski sradevski force-pushed the feat/product-category-hooks branch from 9767241 to 0a2a628 Compare January 24, 2025 07:55
@sradevski sradevski merged commit c1ae373 into medusajs:develop Jan 24, 2025
14 of 22 checks passed
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
* hooks

* workflow result fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants