Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product categories hooks #10287

Closed
wants to merge 265 commits into from
Closed

Conversation

noubase
Copy link
Contributor

@noubase noubase commented Nov 26, 2024

There are three hooks for the basic product categories workflows.

@noubase noubase requested a review from a team as a code owner November 26, 2024 09:53
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 9ae599d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 26, 2024

@noubase is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@noubase
Copy link
Contributor Author

noubase commented Dec 14, 2024

Anybody? @olivermrbl

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 17, 2025
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Jan 22, 2025
@sradevski sradevski reopened this Jan 22, 2025
@sradevski
Copy link
Member

@noubase can you please rebase, and I'll look into having this merged today.

riqwan and others added 16 commits January 22, 2025 17:02
* chore(docs): Generated DML JSON files (automated)

* fixes

---------

Co-authored-by: olivermrbl <[email protected]>
Co-authored-by: Shahed Nasser <[email protected]>
* docs: manually generate references for v2.1.2

* more changes
Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action

Co-authored-by: Oli Juhl <[email protected]>
Co-authored-by: Shahed Nasser <[email protected]>
…ptions (medusajs#10622)

**What**
- add a list point for fetching fulfillment options for a provider
- add FO support on SO create & update on dashboard
- pass `cart` and `stockLocation` to `validateFufillmentData` context

---

CLOSES CMRC-789
CLOSES CMRC-790
* feat: Custom line items

* fix tests

* fix migration

* Allow custom items in update line item workflow

* throw if line item doesn't have a price

* minor things

* wip

* fix flows

* fix test

* add default

* add to type
**What**
Keep the autocompletion for the fields API in Query APIs while being more flexible in order to prevent limitation from our depth limit but also to be more flexible when assigning string[] coming from the API for example.
riqwan and others added 16 commits January 22, 2025 17:05
…#10915)

what:

- fixes eval conditions for promotion rules

RESOLVES CMRC-851
PARTIALLY RESOLVES FRMW-2876

**What**
Fix wrong usage of the `subscriberId` in the event bus. It happens that the subscriber id coming from the context was not used at all. This issue lead to duplicated event subscriber with the same subscriber id, it also prevent unsubscribing from event since rand id will be assigned.

**NOTE**
This PR does not handle overide strategy for subscribers with the same id. this still needs to be discussed
…ajs#11048)

FIXES FRMW-2878

**What**
Currently, the `one-to-one` unique constraints does not account for deleted record. This prevents from inserting a new record wth the same fk if another one is deleted.

**Caveat**
`hasOne` with FK option is meant to be a special case, for example a many to one - one to many without defining the other side of the relation. In that case we don't handle this behaviour and keep it as it is
**What**
- Sends variant_rank to the backend
- Sorts variant table by variant_rank if no other order is selected.

We have a project planned for implementing variant_rank correctly, and adding UI for managing the rank after product creation. This PR handles none of that, as it should be handled as part of said project. This PR simply makes the field useable until then.

Resolves CMRC-859
**What**
- Fixes an issue that would cause the Checkbox indicator to get rendered outside of view in the checkbox was wrapped in a relative div.
Resolves CMRC-627

**What**
- If the session expired, and the user then navigated to a route with no loader the request for the user info in the sidebar would fail causing the app to crash as we didn't have an errorElement wrapping the app shell.
- This PR adds a top level errorElement which handles errors that are outside of a page context, such as in the sidebar.
…edusajs#11058)

**What**
- Updates the Users table to use the new DataTable
- Fixes an issue where initial parsing of URL filters weren't formatted correctly.
Removing the import allows future compatibilty with tailwind v4 where it won't be exported anymore. Fix medusajs#11040
Co-authored-by: Kasper Fabricius Kristensen <[email protected]>
* Add Romanian translation

* romanian added
@noubase noubase requested review from a team as code owners January 22, 2025 15:05
@noubase
Copy link
Contributor Author

noubase commented Jan 22, 2025

@noubase can you please rebase, and I'll look into having this merged today.

Ah, I messed everything up during the rebase. Forget it—never mind

@sradevski
Copy link
Member

@noubase maybe just open a new PR? :)

@noubase
Copy link
Contributor Author

noubase commented Jan 22, 2025

The new pull request from my branch only shows this PR.

@noubase
Copy link
Contributor Author

noubase commented Jan 22, 2025

I honestly can’t tell if this PR is broken or not :)

@sradevski
Copy link
Member

@noubase it has 265 commits, so it's definitely not how it's supposed to be :)

Just create a new branch and new PR maybe?

@noubase
Copy link
Contributor Author

noubase commented Jan 22, 2025

@noubase it has 265 commits, so it's definitely not how it's supposed to be :)

Just create a new branch and new PR maybe?

#11093

@github-actions github-actions bot removed the Stale label Jan 23, 2025
@sradevski sradevski closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.