Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(medusa, admin-ui): Update edit allocation modal #4071

Merged
merged 7 commits into from
May 22, 2023

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented May 11, 2023

What

  • update the design of the edit-allocation modal adding "description" and "metadata" capabilities
  • Make line-item optional in the edit-allocation modal in prep for reservation management

Fixes CORE-1385

@pKorsholm pKorsholm requested a review from a team as a code owner May 11, 2023 08:33
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2023

🦋 Changeset detected

Latest commit: 5af2462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@medusajs/medusa Patch
@medusajs/admin-ui Patch
@medusajs/admin Patch
@medusajs/medusa-js Patch
medusa-payment-paypal Patch
medusa-payment-stripe Patch
medusa-plugin-restock-notification Patch
medusa-react Patch
@medusajs/medusa-oas-cli Patch
@medusajs/oas-github-ci Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 1:42pm

@pKorsholm pKorsholm marked this pull request as draft May 11, 2023 08:57
@pKorsholm pKorsholm marked this pull request as ready for review May 11, 2023 09:22
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments to the edit allocation modal in #4081. Let me know, if you want me to move them here :)

@pKorsholm
Copy link
Contributor Author

I've added comments to the edit allocation modal
@olivermrbl I think it's fine, I'll port over the changes

@pKorsholm pKorsholm requested a review from olivermrbl May 19, 2023 09:01
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants