feat(admin-ui,medusa): Reservations management #4081

pKorsholm · 2023-05-12T06:47:21Z

What

Add reservations table
Add create-reservations modal

note: filtering is not part of this pr but the boilerplate has been copied over

Fixes CORE-1386

vercel · 2023-05-12T06:47:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2023 5:19pm

changeset-bot · 2023-05-12T06:47:26Z

🦋 Changeset detected

Latest commit: c50594c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@medusajs/client-types	Patch
medusa-react	Patch
@medusajs/medusa-js	Patch
@medusajs/admin-ui	Patch
@medusajs/medusa	Patch
@medusajs/admin	Patch
medusa-payment-paypal	Patch
medusa-payment-stripe	Patch
medusa-plugin-restock-notification	Patch
@medusajs/medusa-oas-cli	Patch
@medusajs/oas-github-ci	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

olivermrbl · 2023-05-16T14:00:49Z

Should this be a quantity picker similar to elsewhere?

olivermrbl · 2023-05-16T14:16:56Z

Would be nice to add a tooltip here stating that we are searching for SKU on inventory items:

SKU is nullable so in case users have not added those, the empty search might cause confusion.

olivermrbl · 2023-05-16T14:20:58Z

Something is off with the font sizing here. The 10 is smaller than the rest

Also, I am not sure the / Requested makes sense. Here I created a reservation of 10 when there were 100 in stock. Am I missing something?

olivermrbl

Very strong work! I've added a couple of initial comments and thoughts. Will give it another review tomorrow :)

Deleting a reservation item succeeds but never closes the confirmation modal. I am struck here:

Switching between locations should clear the selected item:

CleanShot.2023-05-16.at.19.36.43.mp4

Also, a changeset is missing

packages/admin-ui/ui/src/components/molecules/item-search/index.tsx

packages/admin-ui/ui/src/components/molecules/select/next-select/use-select-props.tsx

...dmin-ui/ui/src/components/templates/reservations-table/components/reservation-form/index.tsx

packages/admin-ui/ui/src/components/templates/reservations-table/index.tsx

packages/admin-ui/ui/src/components/templates/reservations-table/new/index.tsx

packages/admin-ui/ui/src/domain/orders/details/allocations/edit-allocation-modal.tsx

olivermrbl

Very strong work! I've added a couple of initial comments and thoughts. Will give it another review tomorrow :)

Deleting a reservation item succeeds but never closes the confirmation modal. I am stuck here:

Switching between locations should clear the selected item:

CleanShot.2023-05-16.at.19.36.43.mp4

Also, a changeset is missing

packages/admin-ui/ui/src/components/templates/reservations-table/index.tsx

packages/admin-ui/ui/src/domain/orders/details/allocations/edit-allocation-modal.tsx

packages/admin-ui/ui/src/components/molecules/item-search/index.tsx

…x.tsx Co-authored-by: Riqwan Thamir <[email protected]>

olivermrbl · 2023-05-22T07:19:14Z

nit: Can we add cache invalidation to transferring reservations from one location to another?

Right now, I am seeing an incorrect availability by doing:

Create reservation -> 10/100 requested
Edit reservation -> Move to another location -> Submit
Edit same reservation -> Change to first location -> Availability at first location is 90
Hard refresh -> Availability at first location is 100

olivermrbl

LGTM, will review filters separately 💪

Great work @pKorsholm !

packages/generated/client-types/src/lib/models/DecoratedInventoryItemDTO.ts

olivermrbl · 2023-05-22T07:38:49Z

packages/admin-ui/ui/src/domain/orders/details/allocations/edit-allocation-modal.tsx

 import Button from "../../../../components/fundamentals/button"
 import CrossIcon from "../../../../components/fundamentals/icons/cross-icon"
+import InputField from "../../../../components/molecules/input"
+import { LineItem } from "@medusajs/medusa"


suggestion: Create type to live in @medusajs/types

adrien2p

LGTM w/ comment

adrien2p · 2023-05-22T09:10:40Z

packages/medusa/src/api/routes/admin/inventory-items/index.ts

+ *         type: number
+ *         description: The total quantity of the item available across levels
+ */
+export type DecoratedInventoryItemDTO = InventoryItemDTO & {


suggestion: should this move to the types package? Maybe not now since there is a coupling with the variant but the idea would be to have a variant dto as well, we should get rid of returning entity type as it forces us to be structured around the ORM

packages/medusa/src/api/routes/admin/inventory-items/list-inventory-items.ts

adrien2p · 2023-05-22T09:14:57Z

packages/medusa/src/api/routes/admin/reservations/index.ts

+ *         description: inventory item from inventory module
+ *         $ref: "#/components/schemas/InventoryItemDTO"
+ */
+export type ExtendedReservationItem = ReservationItemDTO & {


same as the previous comment, but probably not as part of that pr but as we move towards modules

packages/medusa/src/api/routes/admin/reservations/list-reservations.ts

…oryItemDTO.ts Co-authored-by: Oliver Windall Juhl <[email protected]>

pKorsholm marked this pull request as ready for review May 12, 2023 08:24

pKorsholm requested a review from a team as a code owner May 12, 2023 08:24

vercel bot deployed to Preview May 15, 2023 11:45 View deployment

vercel bot deployed to Preview May 16, 2023 11:37 View deployment

pKorsholm force-pushed the feat/reservations-management branch from 908ea81 to 945dd53 Compare May 16, 2023 13:26

olivermrbl requested changes May 16, 2023

View reviewed changes

olivermrbl changed the title ~~Feat/reservations management~~ feat(admin-ui,medusa): Reservations management May 17, 2023

olivermrbl requested changes May 17, 2023

View reviewed changes

olivermrbl mentioned this pull request May 18, 2023

Feat(medusa, admin-ui): Update edit allocation modal #4071

Merged

pKorsholm and others added 15 commits May 19, 2023 10:33

add location filtering to list-location levels

8dcd47d

cleanup

53a2040

add location filtering to list-location levels

3c99ec5

cleanup

9852ac0

Initial work on route,table,new reservation form

2065495

generated types

19a6d35

add block

ae16a8f

udpate clients

bc01a04

initial create reservation

f895d30

update actionables for reservation table

be797c3

update edit-allocation modal

9bd46f7

misc naming updates

48a1f71

update reservations table

f6ee0eb

add expand capabilities for list-reservations

b2c3092

expand fields and show columns

e64639d

pKorsholm added 3 commits May 19, 2023 10:33

cleanup reservations table + select

43ca9ae

add decorated inventory item type

15f5bdd

use type

d480350

pKorsholm force-pushed the feat/reservations-management branch from 8c76592 to d480350 Compare May 19, 2023 08:34

feedback changes

79b56ea

pKorsholm requested a review from olivermrbl May 19, 2023 09:01

riqwan reviewed May 19, 2023

View reviewed changes

packages/admin-ui/ui/src/components/molecules/item-search/index.tsx Outdated Show resolved Hide resolved

packages/admin-ui/ui/src/components/molecules/item-search/index.tsx Outdated Show resolved Hide resolved

pKorsholm and others added 3 commits May 22, 2023 06:27

Update packages/admin-ui/ui/src/components/molecules/item-search/inde…

9644ffe

…x.tsx Co-authored-by: Riqwan Thamir <[email protected]>

decorate response for list inventory item to include total quantities

fc4100b

Merge branch 'develop' into feat/reservations-management

46d2f3e

vercel bot deployed to Preview May 22, 2023 06:54 View deployment

pKorsholm and others added 3 commits May 22, 2023 09:14

update decorated properties

850b668

decorate type

ea0bf75

Merge branch 'develop' into feat/reservations-management

e9fbea2

vercel bot deployed to Preview May 22, 2023 07:22 View deployment

olivermrbl approved these changes May 22, 2023

View reviewed changes

adrien2p approved these changes May 22, 2023

View reviewed changes

adrien feedback

1f86076

pKorsholm mentioned this pull request May 22, 2023

feat(admin-ui): Filter reservations #4115

Merged

pKorsholm and others added 5 commits May 22, 2023 18:10

Update packages/generated/client-types/src/lib/models/DecoratedInvent…

24a3dd9

…oryItemDTO.ts Co-authored-by: Oliver Windall Juhl <[email protected]>

update join-utils

a628cde

fix caching

c7be80c

Merge branch 'develop' into feat/reservations-management

1005370

Merge branch 'develop' into feat/reservations-management

c50594c

vercel bot deployed to Preview May 22, 2023 17:19 View deployment

pKorsholm merged commit 4f3c8f5 into develop May 23, 2023

pKorsholm mentioned this pull request May 23, 2023

feat(medusa, inventory): Search inventory items by title and description #4154

Merged

This was referenced May 24, 2023

Version Packages #4114

Merged

Version Packages olivermrbl/medusa#42

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(admin-ui,medusa): Reservations management #4081

feat(admin-ui,medusa): Reservations management #4081

pKorsholm commented May 12, 2023 •

edited

Loading

vercel bot commented May 12, 2023 •

edited

Loading

changeset-bot bot commented May 12, 2023 •

edited

Loading

olivermrbl commented May 16, 2023

olivermrbl commented May 16, 2023 •

edited

Loading

olivermrbl commented May 16, 2023 •

edited

Loading

olivermrbl left a comment

olivermrbl left a comment •

edited

Loading

olivermrbl commented May 22, 2023

olivermrbl left a comment

olivermrbl May 22, 2023

adrien2p left a comment

adrien2p May 22, 2023

adrien2p May 22, 2023

feat(admin-ui,medusa): Reservations management #4081

feat(admin-ui,medusa): Reservations management #4081

Conversation

pKorsholm commented May 12, 2023 • edited Loading

vercel bot commented May 12, 2023 • edited Loading

changeset-bot bot commented May 12, 2023 • edited Loading

🦋 Changeset detected

olivermrbl commented May 16, 2023

olivermrbl commented May 16, 2023 • edited Loading

olivermrbl commented May 16, 2023 • edited Loading

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl left a comment • edited Loading

Choose a reason for hiding this comment

olivermrbl commented May 22, 2023

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl May 22, 2023

Choose a reason for hiding this comment

adrien2p left a comment

Choose a reason for hiding this comment

adrien2p May 22, 2023

Choose a reason for hiding this comment

adrien2p May 22, 2023

Choose a reason for hiding this comment

pKorsholm commented May 12, 2023 •

edited

Loading

vercel bot commented May 12, 2023 •

edited

Loading

changeset-bot bot commented May 12, 2023 •

edited

Loading

olivermrbl commented May 16, 2023 •

edited

Loading

olivermrbl commented May 16, 2023 •

edited

Loading

olivermrbl left a comment •

edited

Loading