-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-ui): Filter reservations #4115
Conversation
🦋 Changeset detectedLatest commit: a189831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
9fdff25
to
5289fa0
Compare
8c76592
to
d480350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ve only reviewed the backenmd for now
packages/medusa/src/api/routes/admin/reservations/create-reservation.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/reservations/list-reservations.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/reservations/utils/join-inventory-items.ts
Outdated
Show resolved
Hide resolved
packages/medusa/src/api/routes/admin/reservations/utils/join-line-items.ts
Outdated
Show resolved
Hide resolved
fe21bce
to
550b6db
Compare
550b6db
to
a5efef7
Compare
897f4b5
to
857d6fa
Compare
c1eb845
to
1ecf324
Compare
62e9de7
to
f3a5bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic work @pKorsholm !! 🚀
only minuscule todos
packages/admin-ui/ui/src/components/atoms/date-picker/date-picker.tsx
Outdated
Show resolved
Hide resolved
packages/admin-ui/ui/src/components/templates/reservations-table/index.tsx
Outdated
Show resolved
Hide resolved
packages/admin-ui/ui/src/components/molecules/select/next-select/components/single-value.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
epic work @pKorsholm !! 🚀
only minuscule todos
Also, missing a changeset :) |
…le/index.tsx Co-authored-by: Oliver Windall Juhl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - love it!
@adrien2p will you check if your requested changes have been addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me, the bnackend comments have been addressed in another pr 💪
* initial filter * clenaup * reser filters correctly * filter reservations * ensure reset works * update types * add adjustment icon * pr prep * update filtering with proper description handling * location filter updates and search removal * removed greyed out dates + add created_by filtering * update filtering with proper ordering * filter out selected users * fix array issues * update spacing for searchable queries * fix deselection bug for inventory item search * update date filter; * rename const a to initialFilters * fix re-render issue * ui updates * update inventory filter to remove selected items * fix width * fix truncation for button text if desired * add span classes * add "go to reservations" popover * add tooltip if location text is truncated * fix long items * typing * minor fix for select value * fix reservation quantity field updates * add pb * Update packages/admin-ui/ui/src/components/templates/reservations-table/index.tsx Co-authored-by: Oliver Windall Juhl <[email protected]> * feedback * add changeset --------- Co-authored-by: Oliver Windall Juhl <[email protected]>
What
Fixes CORE-1387