feat(medusa, inventory): Search inventory items by title and description #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bed480f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
olivermrbl
changed the title
olivermrbl
requested changes
May 23, 2023
|
|
||
| expect(response.data.inventory_items).toHaveLength(3) | ||
| expect(response.data.inventory_items).toEqual( | ||
| expect.arrayContaining([ |
There was a problem hiding this comment.
todo: Please add tests ensuring that unexpected items are not part of the response
There was a problem hiding this comment.
👍 tested to ensure that the default is not part of the result.
the expect on 564 should ensure that only the three objects are part of the result, the arrayContaining is just to ensure ordering doesn't matter
pKorsholm
force-pushed
the
feat/search-inventory-items-by-title-and-description
branch
from
356cbe8 to
bed480f
Compare
This was referenced May 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why