Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(admin-ui): Add missing SO relation #4594

Merged
merged 5 commits into from
Jul 25, 2023
Merged

fix(admin-ui): Add missing SO relation #4594

merged 5 commits into from
Jul 25, 2023

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Jul 24, 2023 •
edited
Loading

Solves #4561

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 26935ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/admin-ui Patch
@medusajs/admin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 10:53am

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: edf93d9

@olivermrbl
Copy link
Contributor Author

/snapshot-this

@github-actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: d2a8cf0

@olivermrbl olivermrbl marked this pull request as ready for review July 25, 2023 07:55
@olivermrbl olivermrbl requested a review from a team as a code owner July 25, 2023 07:55
@adrien2p
Copy link
Member

@olivermrbl here the fix #4600

@olivermrbl olivermrbl force-pushed the fix/missing-return-relation branch from 93b1e4f to 26935ff Compare July 25, 2023 10:49
@olivermrbl
Copy link
Contributor Author

@adrien2p – shipping option is still missing, so this PR is relevant

@adrien2p
Copy link
Member

@adrien2p – shipping option is still missing, so this PR is relevant

yes both pr needs to be integrated right?

@olivermrbl
Copy link
Contributor Author

Yep !

@olivermrbl olivermrbl requested a review from adrien2p July 25, 2023 14:14
adrien2p
adrien2p approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit aab8901 into develop Jul 25, 2023
@olivermrbl olivermrbl deleted the fix/missing-return-relation branch July 25, 2023 15:28
@github-actions github-actions bot mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
version: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olivermrbl @adrien2p